From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/busybox: disable stack optimization for i386 target
Date: Thu, 11 May 2023 22:49:45 +0200 [thread overview]
Message-ID: <20230511204945.GN252090@scaer> (raw)
In-Reply-To: <20230511204402.GM252090@scaer>
Romain, All,
On 2023-05-11 22:44 +0200, Yann E. MORIN spake thusly:
> On 2023-02-11 00:36 +0100, Romain Naour spake thusly:
> > Disabling CONFIG_STACK_OPTIMIZATION_386 option (as suggested in the Gentoo bug report) fixed the issue!
> Applied to master, thanks.
Additionally, I think we should also enforce that with something like:
ifeq ($(BR2_i386),y)
define BUSYBOX_NO_STACK_OPTIM
$(call KCONDFIG_DISABLE_OPT,CONFIG_STACK_OPTIMIZATION_386)
endef
endif
... so that we are also covered when the user provides their custom
config file.
Honestly, I think that i386-based systems are rather on the big side of
the spectrum, such that the gain from optimising the stack to a non-
standard alignment would be hidden in the measurement noise...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-05-11 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 23:36 [Buildroot] [PATCH] package/busybox: disable stack optimization for i386 target Romain Naour
2023-02-11 9:49 ` Thomas Petazzoni via buildroot
2023-02-11 10:10 ` Romain Naour
2023-05-10 10:06 ` Romain Naour
2023-06-12 20:16 ` Peter Korsgaard
2023-05-11 20:44 ` Yann E. MORIN
2023-05-11 20:49 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511204945.GN252090@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox