Re: [Buildroot] [RFC v1] package/python-babel: add purge locale data support

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Peter, All,

On 2023-04-18 23:32 +0200, Peter Seiderer spake thusly:
> Add purge loacle data support (inspired by BR2_ENABLE_LOCALE_PURGE
> handling in Makefile) to reduce target space allocation by the
> python-babel package, e.g. from 32MB to 24K for
> target/usr/lib/python3.11/site-packages/babel/locale-data with
> BR2_ENABLE_LOCALE_WHITELIST="C en_US de_DE".
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/python-babel/python-babel.mk | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/package/python-babel/python-babel.mk b/package/python-babel/python-babel.mk
> index 890a8b02b9..ea383e9c05 100644
> --- a/package/python-babel/python-babel.mk
> +++ b/package/python-babel/python-babel.mk
> @@ -12,5 +12,17 @@ PYTHON_BABEL_LICENSE = BSD-3-Clause
>  PYTHON_BABEL_LICENSE_FILES = LICENSE
>  HOST_PYTHON_BABEL_DEPENDENCIES = host-python-pytz
>  
> +# purge locale data (if enabled), keep special en_US_POSIX data by default
> +ifeq ($(BR2_ENABLE_LOCALE_PURGE),y)
> +define PYTHON_BABEL_CLEANUP_LOCALE
> +	for i in `ls $(TARGET_DIR)/usr/lib/python3.11/site-packages/babel/locale-data/*.dat`; \
> +	do \
> +		i_base=`basename "$$i" .dat`; \
> +		echo "$(BR2_ENABLE_LOCALE_WHITELIST) en_US_POSIX" | grep -qw "$$i_base" || rm "$$i"; \

Why do you force keeping the en_US_POSIX locale specifically?

If there is the need that at least one locale be present, then can we
keep a more generic one, like 'C', or 'POSIX', or whatever is not
specific to a country?

> +	done
> +endef
> +endif
> +PYTHON_BABEL_POST_INSTALL_TARGET_HOOKS += PYTHON_BABEL_CLEANUP_LOCALE

Like for the toolchain locale purge, it should be a target-fnalize hook;
    PYTHON_BABEL_TARGET_FINALIZE_HOOKS

(Note that the systemd locale purge is done as a ROOTFS_PRE_CMD_HOOKS,
but that is wrong, IMNSHO, and it too should have been a target finalize
hook.)

Regards,
Yann E. MORIN.

>  $(eval $(python-package))
>  $(eval $(host-python-package))
> -- 
> 2.40.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot