From: unixmania@gmail.com
To: buildroot@buildroot.org
Cc: Carlos Santos <unixmania@gmail.com>,
Romain Naour <romain.naour@gmail.com>
Subject: [Buildroot] [PATCH v3] package/qemu: install keyboard maps only if necessary
Date: Wed, 24 May 2023 10:31:38 -0300 [thread overview]
Message-ID: <20230524133138.60117-1-unixmania@gmail.com> (raw)
From: Carlos Santos <unixmania@gmail.com>
They are required only for system emulation, so pull a patch already
reviewd upstream that makes the installation conditional:
https://patchwork.kernel.org/project/qemu-devel/patch/20230327172147.196607-1-casantos@redhat.com/
Signed-off-by: Carlos Santos <unixmania@gmail.com>
---
Changes v1->v2
- Fixed reference to uptream patch, using the QEMU patchwork
Changes v2->v3
- Fix SOB, as required by the Buildroot policy
---
...tall-keyboard-maps-only-if-necessary.patch | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch
diff --git a/package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch b/package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch
new file mode 100644
index 0000000000..be9d0ad59e
--- /dev/null
+++ b/package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch
@@ -0,0 +1,37 @@
+From 9d9b74f806f5dbca53df6630c1a0591eaedd4500 Mon Sep 17 00:00:00 2001
+From: Carlos Santos <casantos@redhat.com>
+Date: Sun, 1 Jan 2023 21:00:57 -0300
+Subject: [PATCH] meson: install keyboard maps only if necessary
+
+They are required only for system emulation (i.e. have_system is true).
+
+Signed-off-by: Carlos Santos <casantos@redhat.com>
+Signed-off-by: Carlos Santos <unixmania@gmail.com>
+---
+ pc-bios/keymaps/meson.build | 6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+diff --git a/pc-bios/keymaps/meson.build b/pc-bios/keymaps/meson.build
+index 158a3b410c..bff3083313 100644
+--- a/pc-bios/keymaps/meson.build
++++ b/pc-bios/keymaps/meson.build
+@@ -47,7 +47,7 @@ if native_qemu_keymap.found()
+ build_by_default: true,
+ output: km,
+ command: [native_qemu_keymap, '-f', '@OUTPUT@', args.split()],
+- install: true,
++ install: have_system,
+ install_dir: qemu_datadir / 'keymaps')
+ endforeach
+
+@@ -56,4 +56,6 @@ else
+ install_data(keymaps.keys(), install_dir: qemu_datadir / 'keymaps')
+ endif
+
+-install_data(['sl', 'sv'], install_dir: qemu_datadir / 'keymaps')
++if have_system
++ install_data(['sl', 'sv'], install_dir: qemu_datadir / 'keymaps')
++endif
+--
+2.31.1
+
--
2.31.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2023-05-24 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 13:31 unixmania [this message]
2023-07-12 21:41 ` [Buildroot] [PATCH v3] package/qemu: install keyboard maps only if necessary Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524133138.60117-1-unixmania@gmail.com \
--to=unixmania@gmail.com \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox