Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/hwdata: install to staging
Date: Sun, 18 Jun 2023 18:20:30 +0200	[thread overview]
Message-ID: <20230618162030.GA2754@scaer> (raw)
In-Reply-To: <20230507142319.1001150-1-bernd.kuhls@t-online.de>

Bernd, All,

On 2023-05-07 16:23 +0200, Bernd Kuhls spake thusly:
> Build-time dependency for the new libdisplay-info package.

I've substantially expanded on the commit log, to explain _why_ it needs
to be installed to staging.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/hwdata/hwdata.mk | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/package/hwdata/hwdata.mk b/package/hwdata/hwdata.mk
> index 755a9c93f1..cbac3a22d4 100644
> --- a/package/hwdata/hwdata.mk
> +++ b/package/hwdata/hwdata.mk
> @@ -8,6 +8,7 @@ HWDATA_VERSION = 0.369
>  HWDATA_SITE = $(call github,vcrhonek,hwdata,v$(HWDATA_VERSION))
>  HWDATA_LICENSE = GPL-2.0+, BSD-3-Clause, XFree86 1.0
>  HWDATA_LICENSE_FILES = COPYING LICENSE
> +HWDATA_INSTALL_STAGING = YES
>  
>  HWDATA_FILES = \
>  	$(if $(BR2_PACKAGE_HWDATA_IAB_OUI_TXT),iab.txt oui.txt) \
> @@ -15,7 +16,22 @@ HWDATA_FILES = \
>  	$(if $(BR2_PACKAGE_HWDATA_PNP_IDS),pnp.ids) \
>  	$(if $(BR2_PACKAGE_HWDATA_USB_IDS),usb.ids)
>  
> +define HWDATA_CONFIGURE_CMDS
> +	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure)
> +endef
> +
> +define HWDATA_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) hwdata.pc
> +endef
> +
>  ifneq ($(strip $(HWDATA_FILES)),)
> +define HWDATA_INSTALL_STAGING_CMDS
> +	$(INSTALL) -D -m 0644 $(@D)/hwdata.pc \
> +		$(STAGING_DIR)/usr/lib/pkgconfig/hwdata.pc
> +	$(INSTALL) -d -m 755 $(STAGING_DIR)/usr/share/hwdata
> +	$(INSTALL) -m 644 -t $(STAGING_DIR)/usr/share/hwdata \
> +		$(addprefix $(@D)/,$(HWDATA_FILES))
> +endef
>  define HWDATA_INSTALL_TARGET_CMDS
>  	$(INSTALL) -d -m 755 $(TARGET_DIR)/usr/share/hwdata
>  	$(INSTALL) -m 644 -t $(TARGET_DIR)/usr/share/hwdata \
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-06-18 16:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07 14:23 [Buildroot] [PATCH 1/2] package/hwdata: install to staging Bernd Kuhls
2023-05-07 14:23 ` [Buildroot] [PATCH 2/2] package/libdisplay-info: new package Bernd Kuhls
2023-06-18 16:25   ` Yann E. MORIN
     [not found]   ` <20230618162525.GB2754__2479.91979574493$1687105555$gmane$org@scaer>
2023-06-18 18:34     ` Bernd Kuhls
2023-06-18 16:20 ` Yann E. MORIN [this message]
2023-07-06 10:50   ` [Buildroot] [PATCH 1/2] package/hwdata: install to staging Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230618162030.GA2754@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@buildroot.org \
    --cc=eric.le.bihan.dev@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox