From: Peter Seiderer <ps.report@gmx.net>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-good: add adaptivedemux2 plugin option
Date: Thu, 22 Jun 2023 18:46:24 +0200 [thread overview]
Message-ID: <20230622184624.71efcb4b@gmx.net> (raw)
In-Reply-To: <20230622140945.3717948-1-dario.binacchi@amarulasolutions.com>
Hello Dario,
On Thu, 22 Jun 2023 16:09:45 +0200, Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> Currently there is no explicit way to enable/disable the adaptivedemux2
> plugin. Create a menu entry allowing users to disable or enable the plugin,
> like we have for other features.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> package/gstreamer1/gst1-plugins-good/Config.in | 7 +++++++
> package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 6 ++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in
> index d7ec16e80014..3e849307831b 100644
> --- a/package/gstreamer1/gst1-plugins-good/Config.in
> +++ b/package/gstreamer1/gst1-plugins-good/Config.in
> @@ -32,6 +32,13 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_BZ2
> Enable bz2 support for the following plugins:
> matroska
>
> +config BR2_PACKAGE_GST1_PLUGINS_GOOD_ADAPTIVEMUX2
> + bool "Adaptive Streaming 2 support"
> + select BR2_PACKAGE_LIBXML2
> + select BR2_PACKAGE_LIBSOUP
> + help
> + Adaptive Streaming 2 plugin
> +
Please move this somewhere below the 'comment "plugins with external dependencies"' line...
> comment "dependency-less plugins"
>
> config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ALPHA
> diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> index bbcd3aecabd1..c26e32a1841e 100644
> --- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> +++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> @@ -58,6 +58,12 @@ GST1_PLUGINS_GOOD_CONF_OPTS += -Dorc=enabled
> GST1_PLUGINS_GOOD_DEPENDENCIES += orc
> endif
>
> +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_ADAPTIVEMUX2),y)
> +GST1_PLUGINS_GOOD_CONF_OPTS += -Dadaptivedemux2=enabled
Missing:
GST1_PLUGINS_GOOD_DEPENDENCIES += libsoup libxml2
Regards,
Peter
> +else
> +GST1_PLUGINS_GOOD_CONF_OPTS += -Dadaptivedemux2=disabled
> +endif
> +
> ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ALPHA),y)
> GST1_PLUGINS_GOOD_CONF_OPTS += -Dalpha=enabled
> else
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-06-22 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 14:09 [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-good: add adaptivedemux2 plugin option Dario Binacchi
2023-06-22 16:46 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622184624.71efcb4b@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@buildroot.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=michael@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox