[Buildroot] [PATCH v2, 1/1] package/gstreamer1/gst1-plugins-good: add adaptivedemux2 plugin option

[Buildroot] [PATCH v2, 1/1] package/gstreamer1/gst1-plugins-good: add adaptivedemux2 plugin option

[Dario Binacchi]

Currently there is no explicit way to enable/disable the adaptivedemux2
plugin. Create a menu entry allowing users to disable or enable the plugin,
like we have for other features.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

Changes in v2:
- Move the option below the 'comment "plugins with external dependencies"'.
- Add plugin dependencies (i.e. libsoup libxml2) in gst1-plugins-good.mk.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 package/gstreamer1/gst1-plugins-good/Config.in            | 7 +++++++
 package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 7 +++++++
 2 files changed, 14 insertions(+)

diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in
index d7ec16e80014..9d849580c52f 100644
--- a/package/gstreamer1/gst1-plugins-good/Config.in
+++ b/package/gstreamer1/gst1-plugins-good/Config.in
@@ -258,6 +258,13 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_Y4M
 
 comment "plugins with external dependencies"
 
+config BR2_PACKAGE_GST1_PLUGINS_GOOD_ADAPTIVEMUX2
+	bool "Adaptive Streaming 2 support"
+	select BR2_PACKAGE_LIBXML2
+	select BR2_PACKAGE_LIBSOUP
+	help
+	  Adaptive Streaming 2 plugin
+
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_LAME
 	bool "lame (*.mp3 audio encoder)"
 	select BR2_PACKAGE_LAME
diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
index bbcd3aecabd1..41f4c727f3a8 100644
--- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
+++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
@@ -58,6 +58,13 @@ GST1_PLUGINS_GOOD_CONF_OPTS += -Dorc=enabled
 GST1_PLUGINS_GOOD_DEPENDENCIES += orc
 endif
 
+ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_ADAPTIVEMUX2),y)
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dadaptivedemux2=enabled
+GST1_PLUGINS_GOOD_DEPENDENCIES += libsoup libxml2
+else
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dadaptivedemux2=disabled
+endif
+
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ALPHA),y)
 GST1_PLUGINS_GOOD_CONF_OPTS += -Dalpha=enabled
 else
-- 
2.32.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/gstreamer1/gst1-plugins-good: add adaptivedemux2 plugin option

[Yann E. MORIN]

Dario, All,

On 2023-06-22 23:39 +0200, Dario Binacchi spake thusly:
> Currently there is no explicit way to enable/disable the adaptivedemux2
> plugin. Create a menu entry allowing users to disable or enable the plugin,
> like we have for other features.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
> Changes in v2:
> - Move the option below the 'comment "plugins with external dependencies"'.
> - Add plugin dependencies (i.e. libsoup libxml2) in gst1-plugins-good.mk.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>  package/gstreamer1/gst1-plugins-good/Config.in            | 7 +++++++
>  package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 7 +++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in
> index d7ec16e80014..9d849580c52f 100644
> --- a/package/gstreamer1/gst1-plugins-good/Config.in
> +++ b/package/gstreamer1/gst1-plugins-good/Config.in
> @@ -258,6 +258,13 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_Y4M
>  
>  comment "plugins with external dependencies"
>  
> +config BR2_PACKAGE_GST1_PLUGINS_GOOD_ADAPTIVEMUX2
> +	bool "Adaptive Streaming 2 support"

Looking arouund, it looks like the other prompts use the plugin name
with an optional description between parenthesis. So I tweaked this
prompt accordingly.

> +	select BR2_PACKAGE_LIBXML2
> +	select BR2_PACKAGE_LIBSOUP
> +	help
> +	  Adaptive Streaming 2 plugin

A help text that jsut repeats the prompt is plain useless, so I dropped
it. (yes, we do have a lot of that in three; it's historical bagage, and
there's no reason to add more...)

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_LAME
>  	bool "lame (*.mp3 audio encoder)"
>  	select BR2_PACKAGE_LAME
> diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> index bbcd3aecabd1..41f4c727f3a8 100644
> --- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> +++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> @@ -58,6 +58,13 @@ GST1_PLUGINS_GOOD_CONF_OPTS += -Dorc=enabled
>  GST1_PLUGINS_GOOD_DEPENDENCIES += orc
>  endif
>  
> +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_ADAPTIVEMUX2),y)
> +GST1_PLUGINS_GOOD_CONF_OPTS += -Dadaptivedemux2=enabled
> +GST1_PLUGINS_GOOD_DEPENDENCIES += libsoup libxml2
> +else
> +GST1_PLUGINS_GOOD_CONF_OPTS += -Dadaptivedemux2=disabled
> +endif
> +
>  ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ALPHA),y)
>  GST1_PLUGINS_GOOD_CONF_OPTS += -Dalpha=enabled
>  else
> -- 
> 2.32.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot