Re: [Buildroot] [PATCH] package/python-setuptools: add missing dependency on host-python-wheel

["Yann E. MORIN" <yann.morin.1998@free.fr>]

James, All,

On 2023-06-26 22:29 +0200, Romain Naour spake thusly:
> While migrating to pep517 build backend the host-python-wheel
> dependency has been added to host-python-setuptools but
> not to python-setuptools.
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/4537951715
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/python-setuptools/python-setuptools.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/python-setuptools/python-setuptools.mk b/package/python-setuptools/python-setuptools.mk
> index d957930455..39ead10f55 100644
> --- a/package/python-setuptools/python-setuptools.mk
> +++ b/package/python-setuptools/python-setuptools.mk
> @@ -12,6 +12,7 @@ PYTHON_SETUPTOOLS_LICENSE_FILES = LICENSE
>  PYTHON_SETUPTOOLS_CPE_ID_VENDOR = python
>  PYTHON_SETUPTOOLS_CPE_ID_PRODUCT = setuptools
>  PYTHON_SETUPTOOLS_SETUP_TYPE = pep517
> +PYTHON_SETUPTOOLS_DEPENDENCIES = host-python-wheel
>  HOST_PYTHON_SETUPTOOLS_DEPENDENCIES = host-python-wheel

Should this not be done in the python package infra instead?

I.e. if host-python-wheel is required by the pep517 build backend, then
all packages that are pep517 will need wheel, so it should be done by
the infra rather than by each individual package...

Of course, by the virtue of being a dependency of python-setuptools, it
becomes a dependency of all python-packages that already depends on
{host-,}python-setuptools, so it technically works, even with PPD.
Nonetheless, it is semantically incorrect.

Or did I miss something?

Regards,
Yann E. MORIN.

>  $(eval $(python-package))
> -- 
> 2.41.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot