From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libnatpmp: fix header install
Date: Mon, 3 Jul 2023 22:30:26 +0200 [thread overview]
Message-ID: <20230703203026.GL2510@scaer> (raw)
In-Reply-To: <20230703202011.1995452-1-bernd@kuhls.net>
Bernd, All,
On 2023-07-03 22:20 +0200, Bernd Kuhls spake thusly:
> Upstream renamed declspec.h to natpmp_declspec.h
> https://github.com/miniupnp/libnatpmp/commit/1d113363980a98a5868ff2c2b05d7c94e3a18a70
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
Applied to master, thanks. But see a question, below...
> ---
> package/libnatpmp/libnatpmp.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libnatpmp/libnatpmp.mk b/package/libnatpmp/libnatpmp.mk
> index 3a625ea0fe..99d46d814a 100644
> --- a/package/libnatpmp/libnatpmp.mk
> +++ b/package/libnatpmp/libnatpmp.mk
> @@ -18,7 +18,7 @@ endef
> define LIBNATPMP_INSTALL_STAGING_CMDS
> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
> PREFIX=$(STAGING_DIR) \
> - HEADERS='declspec.h natpmp.h' \
> + HEADERS='natpmp_declspec.h natpmp.h' \
So it means 0e258b6190a5 (package/libnatpmp: bump version to 20230423)
was not build-tested before being submitted? At least transmission
unonditionally uses it, so a runtime test of transmission would catch
it.
Regards,
Yann E. MORIN.
> $(TARGET_CONFIGURE_OPTS) install
> endef
>
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-03 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 20:20 [Buildroot] [PATCH 1/1] package/libnatpmp: fix header install Bernd Kuhls
2023-07-03 20:30 ` Yann E. MORIN [this message]
[not found] ` <20230703203026.GL2510__34801.2332267658$1688416254$gmane$org@scaer>
2023-07-03 20:40 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703203026.GL2510@scaer \
--to=yann.morin.1998@free.fr \
--cc=bernd@kuhls.net \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox