Re: [Buildroot] [PATCH] package/iproute2: add optional dependency on libbpf

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Ignacy,

Thanks for the patch!

On Mon, 3 Jul 2023 12:58:19 +0200
Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr> wrote:

> +ifeq ($(BR2_PACKAGE_LIBBPF),y)
> +IPROUTE2_DEPENDENCIES += libbpf
> +endif

Could you test an improved version that passes LIBBPF_FORCE=on in the
enabled case and LIBBPF_FORCE=off in the disabled case?

According to the configure script:

check_force_libbpf_on()
{
    # if set LIBBPF_FORCE=on but no libbpf support, just exist the config
    # process to make sure we don't build without libbpf.
    if [ "$LIBBPF_FORCE" = on ]; then
        echo "  LIBBPF_FORCE=on set, but couldn't find a usable libbpf"
        exit 1
    fi
}

check_libbpf()
{
    # if set LIBBPF_FORCE=off, disable libbpf entirely
    if [ "$LIBBPF_FORCE" = off ]; then
        echo "no"
        return
    fi

Of course, both the enabled and disabled case need to be verified
before submitting v2 :-)

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot