Re: [Buildroot] [PATCH v2 1/1] package/{gettext-gnu, libtextstyle}: bump to version 0.22

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Vadim Kochan <vadim4j@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/{gettext-gnu, libtextstyle}: bump to version 0.22
Date: Mon, 3 Jul 2023 21:44:41 +0200	[thread overview]
Message-ID: <20230703214441.31bc1281@windsurf> (raw)
In-Reply-To: <20230702180449.527486-1-bernd@kuhls.net>

Hello Bernd,

On Sun,  2 Jul 2023 20:04:49 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Release notes:
> https://lists.gnu.org/archive/html/info-gnu/2020-07/msg00009.html
> https://lists.gnu.org/archive/html/info-gnu/2023-06/msg00003.html
> 
> Removed patch 0001, the patched file is not present in this release.
> Removed patch 0002 which was applied upstream.
> 
> Added comments about other files to be updated during version bumps.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> v2: updated gnutext-tiny as well, added comments for future updates

Thanks for working on this. Unfortunately, this patch doesn't work for
me. First, the update of libtextstyle.hash is missing. As it's trivial,
I fixed it locally (but also updated all comments in gettext-gnu,
gettext-tiny and libtextstyle, both in .mk and .hash file to remind to
update the 2 others). But after fixing that the build fails later in
host-gettext-gnu:

In file included from ../../gettext-runtime/intl/localealias.c:61:
../../gettext-runtime/intl/gettextP.h:71:11: fatal error: libgnuintl.h: No such file or directory
   71 | # include "libgnuintl.h"
      |           ^~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [Makefile:4690: ../../gettext-runtime/intl/msginit-localealias.o] Error 1
make[4]: Leaving directory '/home/thomas/projets/buildroot/output/build/host-gettext-gnu-0.22/gettext-tools/src'
make[3]: *** [Makefile:4036: all] Error 2
make[3]: Leaving directory '/home/thomas/projets/buildroot/output/build/host-gettext-gnu-0.22/gettext-tools/src'
make[2]: *** [Makefile:3434: all-recursive] Error 1
make[2]: Leaving directory '/home/thomas/projets/buildroot/output/build/host-gettext-gnu-0.22/gettext-tools'
make[1]: *** [Makefile:3302: all] Error 2
make[1]: Leaving directory '/home/thomas/projets/buildroot/output/build/host-gettext-gnu-0.22/gettext-tools'
make: *** [package/pkg-generic.mk:293: /home/thomas/projets/buildroot/output/build/host-gettext-gnu-0.22/.stamp_built] Error 2

My defconfig is:

BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
BR2_SYSTEM_ENABLE_NLS=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_LIBFUSE=y
# BR2_TARGET_ROOTFS_TAR is not set

Could you have a look at this?

It would be really awesome to have some test cases in support/testing/
to test the gettext support. Because it's quite tricky to test/remember
the different combinations. Sometimes gettext-tiny is used (!NLS),
sometimes gettext-gnu (NLS). Sometimes only the host variant is used,
sometimes the target variant is needed (to provide libintl). Having a
few test cases each testing one of these situations would be really
awesome. This way we could merge gettext updates with more confidence.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot