Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Samuel Martin <s.martin49@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/putty: bump version to 0.78
Date: Mon, 3 Jul 2023 22:38:20 +0200	[thread overview]
Message-ID: <20230703223820.5c156c60@windsurf> (raw)
In-Reply-To: <20230702110447.1877621-1-bernd@kuhls.net>

Hello Bernd,

On Sun,  2 Jul 2023 13:04:47 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> +PUTTY_DEPENDENCIES += host-pkgconf

= sign was sufficient here.

> -ifeq ($(BR2_PACKAGE_LIBGTK2),y)
> -PUTTY_CONF_OPTS += --with-gtk=2
> +ifeq ($(BR2_PACKAGE_LIBGTK3),y)
> +PUTTY_DEPENDENCIES += libgtk3
> +else ifeq ($(BR2_PACKAGE_LIBGTK2),y)
>  PUTTY_DEPENDENCIES += libgtk2
> -else
> -PUTTY_CONF_OPTS += --without-gtk
>  endif

The Config.in file needed some change, as it talked about GTK2, but now
it should mention GTK2 or GTK3.

I fixed both details and applied to master. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-07-03 20:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-02 11:04 [Buildroot] [PATCH v2 1/1] package/putty: bump version to 0.78 Bernd Kuhls
2023-07-03 20:38 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230703223820.5c156c60@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=s.martin49@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox