Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Wojciech M . Zabolotny" <wzab01@gmail.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-msgpack: add host cython dependency
Date: Mon, 10 Jul 2023 20:03:50 +0200	[thread overview]
Message-ID: <20230710200350.5c72bcab@windsurf> (raw)
In-Reply-To: <20230626080016.2182278-1-james.hilliard1@gmail.com>

On Mon, 26 Jun 2023 02:00:16 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> We need host-python-cython for python-msgpack to build correctly.
> This is a hard error when using a pep517 frontend.
> 
> Fixes:
> * Getting build dependencies for wheel...
> running egg_info
> writing msgpack.egg-info/PKG-INFO
> writing dependency_links to msgpack.egg-info/dependency_links.txt
> writing top-level names to msgpack.egg-info/top_level.txt
> reading manifest file 'msgpack.egg-info/SOURCES.txt'
> reading manifest template 'MANIFEST.in'
> warning: no files found matching '*.c' under directory 'msgpack'
> adding license file 'COPYING'
> writing manifest file 'msgpack.egg-info/SOURCES.txt'
> 
> ERROR Missing dependencies:
> 	Cython~=0.29.30

Could you clarify if this is a current issue in the python-msgpack
package that causes build failures, or if this is in preparation to
move from setuptools to pep517 to build python-msgpack?

If you want us to merge your patches faster, please help us: explain in
the commit log the "WHY" you are doing the change. Your commit log
fails to explain it, and therefore I don't have the context to
understand the motivation of the change.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-07-10 18:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26  8:00 [Buildroot] [PATCH 1/1] package/python-msgpack: add host cython dependency James Hilliard
2023-07-10 18:03 ` Thomas Petazzoni via buildroot [this message]
2023-07-10 20:17   ` James Hilliard
2023-07-11  7:38     ` Thomas Petazzoni via buildroot
2023-07-11  9:35       ` James Hilliard
2023-08-26 22:17         ` Thomas Petazzoni via buildroot
2023-08-27  6:23           ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230710200350.5c72bcab@windsurf \
    --to=buildroot@buildroot.org \
    --cc=asafka7@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wzab01@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox