From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gkrellm: link with -latomic if needed
Date: Mon, 10 Jul 2023 20:32:10 +0200 [thread overview]
Message-ID: <20230710203210.6422a277@windsurf> (raw)
In-Reply-To: <20230618123214.163979-1-bernd@kuhls.net>
Hello Bernd,
On Sun, 18 Jun 2023 14:32:14 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> Fixes:
> http://autobuild.buildroot.net/results/5df/5dffba341cfe5e4d41b3c88e58d92b0747318c07/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/gkrellm/gkrellm.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/package/gkrellm/gkrellm.mk b/package/gkrellm/gkrellm.mk
> index 2a68722663..c9748eb084 100644
> --- a/package/gkrellm/gkrellm.mk
> +++ b/package/gkrellm/gkrellm.mk
> @@ -12,7 +12,13 @@ GKRELLM_LICENSE_FILES = COPYING COPYRIGHT
> GKRELLM_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
> GKRELLM_BUILD_OPTS = \
> STRIP="" \
> - SYS_LIBS=$(TARGET_NLS_LIBS)
> + SYS_LIBS="$(GKRELLM_SYS_LIBS)"
> +
> +GKRELLM_SYS_LIBS=$(TARGET_NLS_LIBS)
Spaces around = needed (fixed when applying).
I've applied, even though I don't think this is the best fix. Indeed,
gkrellm uses pkg-config to detect glib2 and to get its compile/link
flags. So the -latomic should be coming from the glib2 .pc file,
instead of having to be propagated manually to all users of glib2.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-10 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 12:32 [Buildroot] [PATCH 1/1] package/gkrellm: link with -latomic if needed Bernd Kuhls
2023-07-10 18:32 ` Thomas Petazzoni via buildroot [this message]
2023-08-23 11:23 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710203210.6422a277@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox