From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Grzegorz Blach <grzegorz@blach.pl>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/6] package/python-hiredis: bump to version 2.2.3
Date: Wed, 12 Jul 2023 22:57:16 +0200 [thread overview]
Message-ID: <20230712225716.19da51c3@windsurf> (raw)
In-Reply-To: <20230611233619.128038-3-grzegorz@blach.pl>
On Mon, 12 Jun 2023 01:36:16 +0200
Grzegorz Blach <grzegorz@blach.pl> wrote:
> Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
> ---
> ...0001-setup.py-fix-build-with-gcc-4.8.patch | 43 -------------------
> package/python-hiredis/python-hiredis.hash | 4 +-
> package/python-hiredis/python-hiredis.mk | 4 +-
> 3 files changed, 4 insertions(+), 47 deletions(-)
> delete mode 100644 package/python-hiredis/0001-setup.py-fix-build-with-gcc-4.8.patch
I applied this patch, but there were several issues with it:
(1) It was breaking "make legal-info". Indeed the COPYRIGHT file has
been removed, and replaced by a LICENSE file, with different
contents. This required changing the .mk file and .hash file
(2) The commit log was not mentioning was the patch was removed
(3) The .checkpackageignore file was not updated to account for the
removal of the patch.
I've addressed all 3 issues, and applied!
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-12 20:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 23:36 [Buildroot] [PATCH 1/6] package/f2fs-tools: bump to version 1.16.0 Grzegorz Blach
2023-06-11 23:36 ` [Buildroot] [PATCH 2/6] package/graphicsmagick: bump to version 1.3.40 Grzegorz Blach
2023-06-15 6:46 ` Peter Korsgaard
2023-06-16 8:36 ` Peter Korsgaard
2023-06-11 23:36 ` [Buildroot] [PATCH 3/6] package/python-hiredis: bump to version 2.2.3 Grzegorz Blach
2023-07-12 20:57 ` Thomas Petazzoni via buildroot [this message]
2023-06-11 23:36 ` [Buildroot] [PATCH 4/6] package/python-pyjwt: bump to version 2.7.0 Grzegorz Blach
2023-07-12 21:00 ` Thomas Petazzoni via buildroot
2023-06-11 23:36 ` [Buildroot] [PATCH 5/6] package/python-redis: bump to version 4.5.5 Grzegorz Blach
2023-07-12 21:01 ` Thomas Petazzoni via buildroot
2023-06-11 23:36 ` [Buildroot] [PATCH 6/6] package/python-rpi-ws281x: bump to version 5.0.0 Grzegorz Blach
2023-07-12 21:02 ` Thomas Petazzoni via buildroot
2023-07-13 3:24 ` Baruch Siach via buildroot
2023-07-16 21:38 ` Thomas Petazzoni via buildroot
2023-06-15 6:44 ` [Buildroot] [PATCH 1/6] package/f2fs-tools: bump to version 1.16.0 Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712225716.19da51c3@windsurf \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=grzegorz@blach.pl \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox