Re: [Buildroot] [PATCH] package/elfutils: enable building with musl-based toolchains

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Ignacy,

On Fri, 14 Jul 2023 11:08:04 +0200
Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr> wrote:

> Select BR2_PACKAGE_ARGP_STANDALONE as soon as the toolchain is not
> glibc-based and add argp-standalone to build dependencies in that
> case.
> 
> Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr>
> ---
>  package/elfutils/Config.in   | 9 +++------
>  package/elfutils/elfutils.mk | 5 ++++-
>  2 files changed, 7 insertions(+), 7 deletions(-)

This looks very good, and was tested successfully here, but you need to
go through all the reverse dependencies of elfutils, and check if they
can now build with musl. To do that:

$ git grep "select BR2_PACKAGE_ELFUTILS"
package/avrdude/Config.in:      select BR2_PACKAGE_ELFUTILS
package/bpftool/Config.in:      select BR2_PACKAGE_ELFUTILS
package/falcosecurity-libs/Config.in:   select BR2_PACKAGE_ELFUTILS
package/kexec-lite/Config.in:   select BR2_PACKAGE_ELFUTILS
package/libbpf/Config.in:       select BR2_PACKAGE_ELFUTILS
package/ltrace/Config.in:       select BR2_PACKAGE_ELFUTILS
package/makedumpfile/Config.in: select BR2_PACKAGE_ELFUTILS
package/mesa3d/Config.in:       select BR2_PACKAGE_ELFUTILS if BR2_PACKAGE_MESA3D_LLVM
package/mesa3d/Config.in:       select BR2_PACKAGE_ELFUTILS
package/petitboot/Config.in:    select BR2_PACKAGE_ELFUTILS
package/racehound/Config.in:    select BR2_PACKAGE_ELFUTILS

For example, avrdude has:

        depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC # elfutils

which is no longer correct, as elfutils no longer has this dependency.
So you need to evaluate if each of those reverse dependencies now
builds fine with musl, in which case the uclibc || glibc dependency can
be dropped, or if the package still doesn't build with musl, in which
case it's no longer elfutils fault, but some other reason (and the
comment on the uclibc || glibc needs to be updated). As an example,
avrdude now builds fine with musl.

And the fun game is that this work needs to be done recursively: once
you have checked if for example libbpf can now build with musl, you
need to look at the reverse dependencies of libbpf (in this case, only
package/kmemd).

Could you have a look at doing this?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot