Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Kilian Zinnecker via buildroot <buildroot@buildroot.org>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Kilian Zinnecker <kilian.zinnecker@mail.de>,
	Quentin Schulz <quentin.schulz@theobroma-systems.com>,
	Andreas Ziegler <br015@umbiko.net>
Subject: Re: [Buildroot] [PATCH v6 3/3] board/radxa/rock5b: Add sdcard image scripts
Date: Fri, 14 Jul 2023 23:47:03 +0200	[thread overview]
Message-ID: <20230714234703.78d5acc9@windsurf> (raw)
In-Reply-To: <20230714064413.11433-4-kilian.zinnecker@mail.de>

Hello Kilian,

On Fri, 14 Jul 2023 08:44:13 +0200
Kilian Zinnecker via buildroot <buildroot@buildroot.org> wrote:

> This patch adds a readme and post image scripts, generating an
> sdcard.img file, which can be flashed on an SD card to boot the
> Radxa Rock 5B.
> 
> Signed-off-by: Kilian Zinnecker <kilian.zinnecker@mail.de>

This should be squashed in the patch adding the defconfig. Indeed
without this, the defconfig doesn't produce anything that can easily be
booted.

> +rm -rf "${GENIMAGE_TMP}"
> +
> +genimage \
> +  --rootpath "${TARGET_DIR}" \
> +  --tmppath "${GENIMAGE_TMP}" \
> +  --inputpath "${BINARIES_DIR}" \
> +  --outputpath "${BINARIES_DIR}" \
> +  --config "${GENIMAGE_CFG}"

Perhaps you could simply call ./support/scripts/genimage.sh directly?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-07-14 21:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14  6:44 [Buildroot] [PATCH v6 0/3] Add board support for Radxa Rock 5B Kilian Zinnecker via buildroot
2023-07-14  6:44 ` [Buildroot] [PATCH v6 1/3] package: add rockchip-rkbin package Kilian Zinnecker via buildroot
2023-07-14 21:43   ` Thomas Petazzoni via buildroot
2023-07-15 19:47     ` Kilian Zinnecker via buildroot
2023-07-26 18:28       ` Kilian Zinnecker via buildroot
2023-07-26 20:00         ` Thomas Petazzoni via buildroot
2023-07-14  6:44 ` [Buildroot] [PATCH v6 2/3] configs: add rock5b/rock5b_defconfig Kilian Zinnecker via buildroot
2023-07-14 21:44   ` Thomas Petazzoni via buildroot
2023-07-15 19:49     ` Kilian Zinnecker via buildroot
2023-07-14  6:44 ` [Buildroot] [PATCH v6 3/3] board/radxa/rock5b: Add sdcard image scripts Kilian Zinnecker via buildroot
2023-07-14 21:47   ` Thomas Petazzoni via buildroot [this message]
2023-07-15 19:51     ` Kilian Zinnecker via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230714234703.78d5acc9@windsurf \
    --to=buildroot@buildroot.org \
    --cc=br015@umbiko.net \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=kilian.zinnecker@mail.de \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox