From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Sergey Matyukevich <geomatsi@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/rtl8189fs: fix build with big endian
Date: Tue, 18 Jul 2023 11:20:50 +0200 [thread overview]
Message-ID: <20230718112050.6d453ad0@windsurf> (raw)
In-Reply-To: <20230716212856.24353-1-giulio.benetti@benettiengineering.com>
On Sun, 16 Jul 2023 23:28:56 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Add local patch to allow to override CFLAGS and undefine
> CONFIG_LITTLE_ENDIAN by default and use the correct endianness according
> to target architecture.
>
> Upstream: https://github.com/jwrdegoede/rtl8189ES_linux/pull/101
This Upstream tag...
> diff --git a/package/rtl8189fs/0001-Makefile-move-EXTRA_CFLAGS-USER_EXTRA_CFLAGS-at-the-.patch b/package/rtl8189fs/0001-Makefile-move-EXTRA_CFLAGS-USER_EXTRA_CFLAGS-at-the-.patch
> new file mode 100644
> index 0000000000..93ce8ee33e
> --- /dev/null
> +++ b/package/rtl8189fs/0001-Makefile-move-EXTRA_CFLAGS-USER_EXTRA_CFLAGS-at-the-.patch
> @@ -0,0 +1,39 @@
> +From f48d99fab8b79e573850067a3ff2d8c16aa95ce1 Mon Sep 17 00:00:00 2001
> +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +Date: Wed, 28 Sep 2022 21:17:17 +0200
> +Subject: [PATCH] Makefile: move 'EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS)' at the
> + end of EXTRA_FLAGS assignment
> +
> +At the moment USER_EXTRA_CFLAGS can't override local Makfile EXTRA_CFLAGS
> +since it's assigned at the beginning of the Makefile. For example it's not
> +possible to undefine the hardcoded CONFIG_LITTLE_ENDIAN and this doesn't
> +allow to build these modules for big endian architectures. So let's move
> +the assignment of USER_EXTRA_CFLAGS to EXTRA_CFLAGS after the last
> +EXTRA_CFLAGS assignment.
> +
... needs to be here. Otherwise, "make check-package" will complain.
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +---
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-18 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 21:28 [Buildroot] [PATCH] package/rtl8189fs: fix build with big endian Giulio Benetti
2023-07-18 9:20 ` Thomas Petazzoni via buildroot [this message]
2023-07-18 9:36 ` [Buildroot] [PATCH v2] " Giulio Benetti
2023-08-24 21:41 ` Thomas Petazzoni via buildroot
2023-09-13 16:06 ` Peter Korsgaard
2023-07-18 9:38 ` [Buildroot] [PATCH] " Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718112050.6d453ad0@windsurf \
--to=buildroot@buildroot.org \
--cc=geomatsi@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox