Re: [Buildroot] [PATCH v4 00/10] group llvm projects and bump to version 15.0.3

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Sebastian,

On Thu, 15 Jun 2023 15:43:04 +0200
Sebastian Weyer <sebastian.weyer@smile.fr> wrote:

> Lang Daniel (10):
>   package/llvm-project: new group for llvm packages
>   package/llvm: move to llvm-project folder
>   package/lld: move to llvm-project subfolder
>   package/clang: move to llvm-project subfolder
>   package/compiler-rt: move to llvm-project subfolder
>   package/libclc: move to llvm-project subfolder
>   package/llvm-project/llvm-cmake: new package
>   package/llvm-project/llvm-libunwind: new package
>   package/llvm-project: bump to version 15.0.3
>   DEVELOPERS: add Daniel Lang for llvm-project

Thanks a lot, I have applied the entire patch series, with some fairly
small changes:

- I have squashed the patch touching the DEVELOPERS file into the first
  patch adding package/llvm-project in the first place. This ensures
  this directory isn't introduced as an "orphan" directory.

- I have taken care of updating the .checkpackageignore file throughout
  the patch series, which was not taken into account here.

- The final patch doing the big bump forgot the case of
  BR2_PACKAGE_QT5TOOLS_QDOC_TOOL which has a dependency on host-clang
  and therefore now depends on host gcc >= 7. And I see I forgot to
  also update the dependency on gcc >= 7. I'll fix that up.

  In fact, as noted in the definition of this option, there is still
  something wrong here: this qt5tools option only needs host-clang, but
  for some reason, we can only build host-clang when the target
  architecture is supported, which doesn't make much sense. It would be
  nice to look into this.

Thanks a lot for your efforts on this, and sorry for the long delay to
review and merge this.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot