Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/3] package/libopenssl: add -latomic to libcrypto.pc when needed
Date: Fri, 21 Jul 2023 23:04:46 +0200	[thread overview]
Message-ID: <20230721230446.22afa781@windsurf> (raw)
In-Reply-To: <20230721180638.215414-2-bernd@kuhls.net>

Hello Bernd,

On Fri, 21 Jul 2023 20:06:37 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Without this patch openssl adds -latomic only to Libs.private in
> libcrypto.pc.

But this is exactly what's needed. If you add -latomic to Libs: it
means that libraries linking against openssl will also be linked with
libatomic, which is not needed. Libs.private ensures this will only
happen if we're static linking, which is what we want.

Let me sum up:

- With dynamic linking, we want libcrypto.so to be linked against
  libatomic.so. Anything linking against libcrypto.so has nothing to do.

- With static linking, anyone linking against libcrypto.a will need to
  link against libatomic.a as well, which is why it's important for
  libcrypto.pc to carry a Libs.private: -latomic.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-07-21 21:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 18:06 [Buildroot] [PATCH 1/3] package/libopenssl: remove deprecated options Bernd Kuhls
2023-07-21 18:06 ` [Buildroot] [PATCH 2/3] package/libopenssl: add -latomic to libcrypto.pc when needed Bernd Kuhls
2023-07-21 21:04   ` Thomas Petazzoni via buildroot [this message]
2023-07-21 18:06 ` [Buildroot] [PATCH 3/3] package/libopenssl: enable threads on static builds Bernd Kuhls
2023-07-21 21:02 ` [Buildroot] [PATCH 1/3] package/libopenssl: remove deprecated options Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230721230446.22afa781@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox