Re: [Buildroot] [PATCH 1/1] package/supertuxkart: fix build with bluetooth enabled

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Bernd,

On Sun, 16 Jul 2023 15:55:57 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> The wiiuse code force an out-of-tree build:
> https://github.com/supertuxkart/stk-code/blob/master/lib/wiiuse/cmake/cmake-4.0.0-modules/RequireOutOfSourceBuild.cmake#L41
> 
> Fixes a build error not yet caught by the autobuilders:
> 
> -- Configuring WiiUse version 0.15.5
> CMake Error at lib/wiiuse/cmake/cmake-4.0.0-modules/RequireOutOfSourceBuild.cmake:41 (message):
>   You must set a binary directory that is different from your source
>   directory.  You might consider
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/supertuxkart/supertuxkart.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/supertuxkart/supertuxkart.mk b/package/supertuxkart/supertuxkart.mk
> index 1f9ad4102b..6bdd512eac 100644
> --- a/package/supertuxkart/supertuxkart.mk
> +++ b/package/supertuxkart/supertuxkart.mk
> @@ -44,6 +44,7 @@ SUPERTUXKART_CONF_OPTS = -DBUILD_SHARED_LIBS=OFF \
>  ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS),y)
>  SUPERTUXKART_DEPENDENCIES += bluez5_utils
>  SUPERTUXKART_CONF_OPTS += -DUSE_WIIUSE=ON -DUSE_SYSTEM_WIIUSE=ON
> +SUPERTUXKART_SUPPORTS_IN_SOURCE_BUILD = NO

I was not really sure if putting this variable within a conditional was
a good idea. Normally a package either requires out-of-tree build or
doesn't care, and it's probably the first time we have a package that
sometimes requires it, sometimes doesn't. But as it reflects the
reality, I've applied your patch as-is. We'll see if other maintainers
disagree, which I would totally understand.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot