Re: [Buildroot] [PATCH v3 4/4] package/fluent-bit: rework wasm handling

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Thomas,

On Sun, 23 Jul 2023 11:23:14 +0200
Thomas Devoogdt <thomas@devoogdt.com> wrote:

> -if BR2_PACKAGE_FLUENT_BIT
> -
> -config BR2_PACKAGE_FLUENT_BIT_WASM_ARCH_SUPPORTS
> -	bool
> -	# see lib/wasm-micro-runtime-WAMR-1.1.1/README.md#supported-architectures-and-platforms
> -	default y if BR2_arc
> -	default y if BR2_arm || BR2_armeb
> -	default y if BR2_aarch64 || BR2_aarch64_be
> -	default y if BR2_i386 || BR2_x86_64
> -	default y if BR2_RISCV_64
> -	default y if BR2_xtensa
> -
> -config BR2_PACKAGE_FLUENT_BIT_WASM
> -	bool "wasm runtime support"
> -	depends on BR2_INSTALL_LIBSTDCPP
> -	depends on BR2_PACKAGE_FLUENT_BIT_WASM_ARCH_SUPPORTS
> -	help
> -	  Support for WASM-based plugins.

Something that isn't explained in your commit log is why you're making
the wasm feature automatically enabled, rather than optional as it was?

What is the size impact? Would someone possibly want fluent-bit without
wasm support?

> Two failures:
> 
> - sourcery-mips64:
> 
> core/iwasm/common/arch/invokeNative_mips.s: Assembler messages:
> core/iwasm/common/arch/invokeNative_mips.s:58: Error: opcode not
> supported on this processor: mips64r2 (mips64r2) `ldc1 $f12,0($sp)'
> core/iwasm/common/arch/invokeNative_mips.s:59: Error: opcode not
> supported on this processor: mips64r2 (mips64r2) `ldc1 $f14,8($sp)'
> make[4]: *** [src/wasm/CMakeFiles/vmlib-static.dir/build.make:495:
> src/wasm/CMakeFiles/vmlib-static.dir/__/__/lib/wasm-micro-runtime-WAMR-1.1.1/core/iwasm/common/arch/invokeNative_mips.s.o]
> Error 1 make[4]: *** Waiting for unfinished jobs....
> 
> - sourcery-mips:
> 
> core/iwasm/common/arch/invokeNative_mips.s: Assembler messages:
> core/iwasm/common/arch/invokeNative_mips.s:58: Error: opcode not
> supported on this processor: mips32r2 (mips32r2) `ldc1 $f12,0($sp)'
> core/iwasm/common/arch/invokeNative_mips.s:59: Error: opcode not
> supported on this processor: mips32r2 (mips32r2) `ldc1 $f14,8($sp)'
> make[4]: *** [src/wasm/CMakeFiles/vmlib-static.dir/build.make:495:
> src/wasm/CMakeFiles/vmlib-static.dir/__/__/lib/wasm-micro-runtime-WAMR-1.1.1/core/iwasm/common/arch/invokeNative_mips.s.o]
> Error 1 make[4]: *** Waiting for unfinished jobs....
> 
> Fix see:
> https://github.com/bytecodealliance/wasm-micro-runtime/issues/625

This part of your commit log is really not clear: we don't understand
if the issue still exists, or is fixed in your commit. You're passing
-DWAMR_BUILD_INVOKE_NATIVE_GENERAL=1 for MIPS, but your commit log
contains a test-pkg run showing that it still fails to build for MIPS. So?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot