Re: [Buildroot] [PATCH 1/1] arch/Config.in.x86: add MMX instruction set capability for Geode CPU

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Cherniaev Andrei, All,

On 2023-07-23 20:20 +0900, Cherniaev Andrei spake thusly:
> Currently, there is no MMX support for modern GEODE processors in Buildroot.
> Yet, some packages like ffmpeg can leverage it when the package is built.
> 
> Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
> ---
>  arch/Config.in.x86 | 21 +++++++++++++++++----
>  1 file changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
> index c770ae3ffe..288d274b0e 100644
> --- a/arch/Config.in.x86
> +++ b/arch/Config.in.x86
> @@ -521,11 +521,24 @@ config BR2_x86_steamroller
>  	select BR2_X86_CPU_HAS_SSE4
>  	select BR2_X86_CPU_HAS_SSE42
>  config BR2_x86_geode
> -	bool "geode"
> -	# Don't include MMX support because there several variant of geode
> -	# processor, some with MMX support, some without.
> -	# See: http://en.wikipedia.org/wiki/Geode_%28processor%29
> +	bool "geode (no mmx)"
> +	help
> +	  For several variant of geode which have not MMX support.
> +	  See
> +	  https://en.wikipedia.org/wiki/Geode_%28processor%29 to
> +	  determine if your particular Geode processor supports MMX or
> +	  not.
> +	depends on !BR2_x86_64
> +config BR2_x86_geode_mmx
> +	bool "geode (with mmx)"
> +	help
> +	  For several variant of geode which have MMX support.
> +	  See
> +	  https://en.wikipedia.org/wiki/Geode_%28processor%29 to
> +	  determine if your particular Geode processor supports MMX or
> +	  not.
>  	depends on !BR2_x86_64
> +	select BR2_X86_CPU_HAS_MMX

    $ make check-package
    arch/Config.in.x86:531: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)
    arch/Config.in.x86:531: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    arch/Config.in.x86:540: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)
    arch/Config.in.x86:540: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    arch/Config.in.x86:541: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

I've fixed that when applying (the help text errors are spurious, due to
the previous order issue; still I did reflow them too).

Applied to master with those fixes, thanks.

Regards,
Yann E. MORIN.

>  config BR2_x86_c3
>  	bool "Via/Cyrix C3 (Samuel/Ezra cores)"
>  	depends on !BR2_x86_64
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot