From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Alistair Francis <alistair23@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/libopenssl: Copy the crypto include files
Date: Sun, 23 Jul 2023 19:46:05 +0200 [thread overview]
Message-ID: <20230723174605.GO2503916@scaer> (raw)
In-Reply-To: <20230721032102.782318-1-alistair.francis@wdc.com>
Alistair, All,
On 2023-07-21 13:21 +1000, Alistair Francis spake thusly:
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> package/libopenssl/libopenssl.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/libopenssl/libopenssl.mk b/package/libopenssl/libopenssl.mk
> index 7a4e0dfca2..9d44098063 100644
> --- a/package/libopenssl/libopenssl.mk
> +++ b/package/libopenssl/libopenssl.mk
> @@ -127,6 +127,10 @@ endef
>
> define LIBOPENSSL_INSTALL_STAGING_CMDS
> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) install
> + mkdir -p $(STAGING_DIR)/usr/include/crypto
> + $(INSTALL) -m 644 $(@D)/include/crypto/* $(STAGING_DIR)/usr/include/crypto/
> + mkdir -p $(STAGING_DIR)/usr/include/internal
> + $(INSTALL) -m 644 $(@D)/include/internal/* $(STAGING_DIR)/usr/include/internal/
You will have to provide some explanations for this change.
Indeed, as far as I can see, those headers are private headers for
openssl, and are not meant to be installed.
For example, they are not available at all in my Ubuntu 20.04, and I
could not find them in an Ubuntu 23.04 either:
$ apt-file search /usr/include/crypto/
[nada]
So, this commit will need some more details as to why private headers
need to be installed. Or why they are not private but not installed by
default.
Yes, I see that patch 2/2 adding libspdm will probably want those
headers, but that at the very least should be mentioned.
Regards,
Yann E. MORIN.
> endef
>
> define HOST_LIBOPENSSL_INSTALL_CMDS
> --
> 2.40.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-07-23 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 3:21 [Buildroot] [PATCH 1/2] package/libopenssl: Copy the crypto include files Alistair Francis
2023-07-21 3:21 ` [Buildroot] [PATCH 2/2] package/libspdm: Initial commit Alistair Francis
2023-07-23 18:10 ` Yann E. MORIN
2023-07-23 17:46 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230723174605.GO2503916@scaer \
--to=yann.morin.1998@free.fr \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=buildroot@buildroot.org \
--cc=s.martin49@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox