Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: stefan.nickl@gmail.com
Cc: Gary Bisson <bisson.gary@gmail.com>,
	Refik Tuzakli <tuzakli.refik@gmail.com>,
	Fabio Estevam <festevam@gmail.com>,
	Charles Hardin <ckhardin@gmail.com>,
	buildroot@buildroot.org, Maeva Manuel <maeva.manuel@oss.nxp.com>
Subject: Re: [Buildroot] [PATCH v2 1/5] package/freescale-imx/firmware-imx: bump version to 8.20
Date: Wed, 26 Jul 2023 00:01:32 +0200	[thread overview]
Message-ID: <20230725220132.GA3544423@scaer> (raw)
In-Reply-To: <20230724191638.637054-2-Stefan.Nickl@gmail.com>

Stefan, All,

On 2023-07-24 21:16 +0200, stefan.nickl@gmail.com spake thusly:
> From: Stefan Nickl <Stefan.Nickl@gmail.com>
> 
> Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>
> ---
>  package/freescale-imx/firmware-imx/firmware-imx.hash | 6 +++---
>  package/freescale-imx/firmware-imx/firmware-imx.mk   | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/freescale-imx/firmware-imx/firmware-imx.hash b/package/freescale-imx/firmware-imx/firmware-imx.hash
> index eb0c387a..0b3561a9 100644
> --- a/package/freescale-imx/firmware-imx/firmware-imx.hash
> +++ b/package/freescale-imx/firmware-imx/firmware-imx.hash
> @@ -1,5 +1,5 @@
>  # Locally calculated
> -sha256  937e196476b8e95b4b7f2501a14c8326d8a0649f8a3f9228b72373770a08deb3  firmware-imx-8.15.bin
> -sha256  35188e65dbb9c7da4bbcb77c7726e835607f9f41b8b44149806ea51429ca9a31  COPYING
> -sha256  30f61825583b4c26d29a798ad7e4c8ef2f2f390b1e964af302d2dc40e93cb0a4  EULA
> +sha256  f6dc6a5c8fd9b913a15360d3ccd53d188db05a08a8594c518e57622478c72383  firmware-imx-8.20.bin
> +sha256  913ba38d4be97361c3d0fa9bf2f6dbe7b1c0c41213dd268fb6738db9704dbe32  COPYING
> +sha256  4fd8bb45a2ec22117d20cfea84370e2a3a2cd99e8e177138bed0938137b1aeb3  EULA

I see Thomas already inquired about the license changes, and that you
mentioned on your cover letter that it "appears inconsequential".

However, we need the explanations to be in the commit log, not the cover
letter, so that they appear in the history (the cover letter does not
end up in the repository).

And we need the explanations to be explicit, even if terse. In this
case, the bulk of the changes are:
  - update to copyright years (2022 -> 2023)
  - switch from ASCCI double quotes to fancy Unicode ones ("" -> “”)
  - reflow the license text
  - identify new third-parties and their conditions

It does not look like it is changing much.

Care to check the other packages, please?

Regards,
Yann E. MORIN.

>  sha256  40d02f6d6b4e94d9307529408f372f5a9908cf3d156ec533a4e54274b40f271e  SCR.txt
> diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk
> index 4cceb670..66ef8c39 100644
> --- a/package/freescale-imx/firmware-imx/firmware-imx.mk
> +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -FIRMWARE_IMX_VERSION = 8.15
> +FIRMWARE_IMX_VERSION = 8.20
>  FIRMWARE_IMX_SITE = $(FREESCALE_IMX_SITE)
>  FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin
>  
> -- 
> 2.41.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-07-25 22:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24 19:16 [Buildroot] [PATCH v2 0/5] Add FREESCALE_IMX_PLATFORM_IMX8DXL stefan.nickl
2023-07-24 19:16 ` [Buildroot] [PATCH v2 1/5] package/freescale-imx/firmware-imx: bump version to 8.20 stefan.nickl
2023-07-25 22:01   ` Yann E. MORIN [this message]
2023-07-24 19:16 ` [Buildroot] [PATCH v2 2/5] package/freescale-imx/imx-seco: bump version to 5.9.0 stefan.nickl
2023-07-24 19:16 ` [Buildroot] [PATCH v2 3/5] package/freescale-imx/imx-sc-firmware: bump version to 1.15.0 stefan.nickl
2023-07-24 19:16 ` [Buildroot] [PATCH v2 4/5] configs/freescale_imx8dxlevk: new defconfig stefan.nickl
2023-07-24 19:16 ` [Buildroot] [PATCH v2 5/5] Add BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8DXL stefan.nickl
2023-08-06 19:25 ` [Buildroot] [PATCH v2 0/5] Add FREESCALE_IMX_PLATFORM_IMX8DXL Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230725220132.GA3544423@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=bisson.gary@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=ckhardin@gmail.com \
    --cc=festevam@gmail.com \
    --cc=maeva.manuel@oss.nxp.com \
    --cc=stefan.nickl@gmail.com \
    --cc=tuzakli.refik@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox