Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "José Luis Salvador Rufo" <salvador.joseluis@gmail.com>
Cc: Alexander Mukhin <alexander.i.mukhin@gmail.com>,
	Michael Zimmermann <sigmaepsilon92@gmail.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/zfs: fix autotools crosscompilations
Date: Wed, 26 Jul 2023 23:30:12 +0200	[thread overview]
Message-ID: <20230726233012.50b0ac6c@windsurf> (raw)
In-Reply-To: <20230608175538.1347170-1-salvador.joseluis@gmail.com>

Hello José,

On Thu,  8 Jun 2023 19:55:38 +0200
José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:

> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>

Thanks for the contribution, but unfortunately we cannot apply this
patch: it does not explain anything about which "autotools
crosscompilations" issues it is fixing. Are these failures visible in
the autobuilders? If so, what link? If not, what configuration/setup
exhibits the problem, what is the error message, how does the patch fix
the issue?

Could you send an updated patch with a non-empty commit log that
contains a sufficient amount of detail for us to properly
review/understand the change?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-07-26 21:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 17:55 [Buildroot] [PATCH] package/zfs: fix autotools crosscompilations José Luis Salvador Rufo
2023-06-09 19:05 ` Alexander Mukhin
2023-06-12 17:57   ` Arnout Vandecappelle via buildroot
2023-07-26 21:30 ` Thomas Petazzoni via buildroot [this message]
2023-11-12 22:11   ` [Buildroot] [PATCH] package/zfs: fix zfs autotools cross-compilation José Luis Salvador Rufo
2023-11-26 16:21     ` Yann E. MORIN
2023-11-30  8:17     ` Peter Korsgaard
2023-11-12 22:17   ` [Buildroot] [PATCH] package/zfs: fix autotools crosscompilations José Luis Salvador Rufo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230726233012.50b0ac6c@windsurf \
    --to=buildroot@buildroot.org \
    --cc=alexander.i.mukhin@gmail.com \
    --cc=salvador.joseluis@gmail.com \
    --cc=sigmaepsilon92@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox