From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] boot/edk2: remove superfluous =TRUE in DEBUG_ON_SERIAL_PORT macro definition
Date: Fri, 28 Jul 2023 22:26:21 +0200 [thread overview]
Message-ID: <20230728222621.3c866b47@windsurf> (raw)
In-Reply-To: <20230724172426.49958-1-ju.o@free.fr>
On Mon, 24 Jul 2023 19:24:26 +0200
Julien Olivain <ju.o@free.fr> wrote:
> Commit 8e9c8e624f "boot/edk2: introduce a new _OVMF_DEBUG_ON_SERIAL
> option" adds a build macro definition with a "=TRUE" value.
>
> edk2 OVMF readme suggests to define the "DEBUG_ON_SERIAL_PORT" macro
> _without_ the "=TRUE" in [1].
>
> The example build.sh script calls build to set the macro _with_
> "=TRUE" in [2].
>
> The "Build_Utility_Man_Page.rtf" documentation in [3] does not specify
> either what exactly happen when a macro is defined without any value.
>
> Looking at the "build.py" code in [4] shows that a macro definition of
> the form "-DMYMACRO" is indeed equivalent as "-DMYMACRO=TRUE". This
> was also tested with a qemu virt x86_64 grub2 EFI boot image, to
> verify behaviors remain the same.
>
> This commit removes the superfluous "=TRUE" as requested by Yann in [5].
>
> Removing the "=TRUE" make it a bit clearer that it is the macro
> definition itself that will enable the feature, rather than its
> value. Defining, -DDEBUG_ON_SERIAL_PORT=FALSE (OFF, 0, or anything
> else that would suggest the feature is disabled) would do the
> opposite of the desired effect, and enable the feature.
>
> [1] https://github.com/tianocore/edk2/blob/edk2-stable202305/OvmfPkg/README#L95
> [2] https://github.com/tianocore/edk2/blob/edk2-stable202305/OvmfPkg/build.sh#L252
> [3] https://github.com/tianocore/edk2/tree/edk2-stable202305/BaseTools/UserManuals
> [4] https://github.com/tianocore/edk2/blob/edk2-stable202305/BaseTools/Source/Python/build/build.py#L2531
> [5] https://lists.buildroot.org/pipermail/buildroot/2023-July/671059.html
>
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
> boot/edk2/edk2.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-07-28 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 17:24 [Buildroot] [PATCH 1/1] boot/edk2: remove superfluous =TRUE in DEBUG_ON_SERIAL_PORT macro definition Julien Olivain
2023-07-28 20:26 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728222621.3c866b47@windsurf \
--to=buildroot@buildroot.org \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox