From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Christian Stewart <christian@aperture.us>
Cc: Romain Naour <romain.naour@smile.fr>,
Brandon Maier <Brandon.Maier@collins.com>,
Romain Naour <romain.naour@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/util-linux: bump version to 2.39.1
Date: Sat, 29 Jul 2023 18:13:10 +0200 [thread overview]
Message-ID: <20230729161310.GB229077@scaer> (raw)
In-Reply-To: <CA+h8R2qm2i94fcggkXvScyv9unAWa6S6pF8TwYWTQLPt=r9eDw@mail.gmail.com>
Christian, All,
On 2023-07-27 21:24 -0700, Christian Stewart via buildroot spake thusly:
> > > > >>> host-go 1.20.6 Building
> > > > ...
> > > > Building Go toolchain1 using [...]test-output/TestMender/host/lib/go-1.19.10.
> > > > error obtaining VCS status: exit status 128
> > > > Use -buildvcs=false to disable VCS stamping.
> > > >
> > > > [1] https://gitlab.com/buildroot.org/buildroot/-/jobs/4725186525
> It took me a long time to find a reproduction for this issue,
>
> I finally traced it: if there is an invalid .git in any parent
> directory of the GOROOT_BOOTSTRAP, the build will fail. Reproduction:
> # This reproduction sets up a directory structure that breaks Go make.bash.
> # make.bash should not break due to .git files outside of the Go sources.
> #
> # The error specifically occurs when an invalid .git is present in a parent git
> # directory of the GOROOT_BOOTSTRAP. Go issue #61620
> mkdir go-issue-61620
> cd ./go-issue-61620
> wget https://go.dev/dl/go1.19.11.src.tar.gz
> mkdir go-bootstrap
> tar -xf go1.19.11.src.tar.gz -C ./go-bootstrap --strip-components=1
> cd ./go-bootstrap/src/
> bash make.bash
> cd ../../
> wget https://go.dev/dl/go1.20.6.src.tar.gz
> mkdir go
> tar -xf go1.20.6.src.tar.gz -C ./go/ --strip-components=1
> printf "gitdir: ../../does/not/exist/.git" > ./.git
So, I believe this would be fixed by the recent change by Brandon:
90790790925c utils/docker-run: fix support for git-worktrees
Regards,
Yann E. MORIN.
> cd ./go/src/
> GOROOT_BOOTSTRAP=$(pwd)/../../go-bootstrap/ bash make.bash
> # Build fails using -buildvcs=false errors.
> ```
>
> Submitted to the go issue tracker: https://github.com/golang/go/issues/61620
>
> Best regards,
> Christian Stewart
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-07-29 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 21:31 [Buildroot] [PATCH] package/util-linux: bump version to 2.39.1 Romain Naour
2023-07-22 21:26 ` Thomas Petazzoni via buildroot
2023-07-24 1:04 ` Christian Stewart via buildroot
2023-07-27 20:47 ` Romain Naour
2023-07-27 21:20 ` Christian Stewart via buildroot
2023-07-27 21:33 ` Christian Stewart via buildroot
2023-07-28 4:24 ` Christian Stewart via buildroot
2023-07-28 8:37 ` Romain Naour
2023-07-28 13:36 ` Christian Stewart via buildroot
2023-07-29 16:13 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230729161310.GB229077@scaer \
--to=yann.morin.1998@free.fr \
--cc=Brandon.Maier@collins.com \
--cc=buildroot@buildroot.org \
--cc=christian@aperture.us \
--cc=romain.naour@gmail.com \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox