Re: [Buildroot] [PATCH 1/1] package/libglu: bump version to 9.0.3

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libglu: bump version to 9.0.3
Date: Sat, 29 Jul 2023 22:37:49 +0200	[thread overview]
Message-ID: <20230729203749.GA421096@scaer> (raw)
In-Reply-To: <20230729154615.559891-1-bernd@kuhls.net>

Bernd, All,

On 2023-07-29 17:46 +0200, Bernd Kuhls spake thusly:
> Release notes:
> https://lists.freedesktop.org/archives/mesa-announce/2023-July/000725.html
> 
> Upstream dropped autoconf, switch to meson.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to master, thanks.

But see below, please.

> ---
[--SNIP--]
> diff --git a/package/libglu/libglu.mk b/package/libglu/libglu.mk
> index 8820e75d8b..b30187884a 100644
> --- a/package/libglu/libglu.mk
> +++ b/package/libglu/libglu.mk
> @@ -4,12 +4,13 @@
>  #
>  ################################################################################
>  
> -LIBGLU_VERSION = 9.0.2
> +LIBGLU_VERSION = 9.0.3
>  LIBGLU_SITE = https://mesa.freedesktop.org/archive/glu
>  LIBGLU_SOURCE = glu-$(LIBGLU_VERSION).tar.xz
>  LIBGLU_LICENSE = SGI-B-2.0
>  LIBGLU_LICENSE_FILES = include/GL/glu.h

There's been a recent discussion about using source file as license
files, and it turns out that this is generally a bad idea overall,
because it does not allow to easily apply patches from a global
patch-dir, and makes it a bit more complex to also add a patch in
Buildroot:

    https://lore.kernel.org/buildroot/20230727125123.927568-1-herve.codina@bootlin.com/T/#u

So, it would be nice if you could update libglu to use a post-extract
hook to generate a license file, something like;

    LIBGLU_LICENSE_FILES = LICENSE.br-extracted

    define LIBGLU_EXTRA_LICENSE
        awk '
            BEGIN { doprint=1; }
            doprint == 1 { print; }
            $0 ~ /\*\// { doprint = 0; }
        ' "$(@S)/include/GL/glu.h \
        > $(@D)/LICENSE.br-extracted
    endef
    LIBGLU_POST_EXTRACT_HOOKS += LIBGLU_EXTRA_LICENSE

Could you see into it, please?

Regards,
Yann E. MORIN.

>  LIBGLU_INSTALL_STAGING = YES
>  LIBGLU_DEPENDENCIES = libgl host-pkgconf
> +LIBGLU_CONF_OPTS = -Dgl_provider=gl
>  
> -$(eval $(autotools-package))
> +$(eval $(meson-package))
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot