Re: [Buildroot] [PATCH v1 1/1] package/go: add toolchain as dependency of host-go

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Fri, 28 Jul 2023 18:19:46 -0700
Christian Stewart <christian@aperture.us> wrote:

> > to ensure we build a host-go compiler capable of building code for the
> > target if the target is supported, but in all cases builds a Go
> > compiler capable of compiling code for the host. Indeed, host-go might
> > also be needed solely to build host utilities, which would be relevant
> > even if the target architecture isn't supported by Go.  
> 
> I suppose if you don't set CC_FOR_TARGET nor CXX_FOR_TARGET then the
> Go compiler will simply use CC and CXX which are HOSTCC_NOCCACHE and
> HOSTCXX_NOCCACHE.

It'd be nicer to have more certainty than "I suppose" :-)

> I noticed there's already a line which adds toolchain as a dependency
> if cgo is enabled.

Hu, where is that?

> Will mark this patch as not applicable for now and consider why the
> build failed in the TestMender test case when running "make host-go"
> without building the toolchain first. I guess that's a case where cgo
> is not enabled and yet BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS=y.
> 
> We should move the toolchain dependency to be if
> BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS instead of if Cgo is enabled,
> I think.

Possibly, and this would make sense, if indeed Go needs the target
C/C++ compiler to build the target Go stuff.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot