From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Pieter De Gendt <pieter.degendt@gmail.com>,
Samuel Martin <s.martin49@gmail.com>,
Giulio Benetti <giulio.benetti@micronovasrl.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/7] package/libheif: new package
Date: Sun, 30 Jul 2023 12:26:50 +0200 [thread overview]
Message-ID: <20230730122650.5592af4b@windsurf> (raw)
In-Reply-To: <20230708200447.3919009-2-bernd@kuhls.net>
Hello Bernd,
I've applied, but I have some comments below. Giuliu, there is also a
question for you.
On Sat, 8 Jul 2023 22:04:42 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> diff --git a/package/libheif/Config.in b/package/libheif/Config.in
> new file mode 100644
> index 0000000000..9ce507fd24
> --- /dev/null
> +++ b/package/libheif/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_LIBHEIF
> + bool "libheif"
> + # avoid build error
> + # Internal error in emit_expr_encoded at dw2gencfi.c:215
> + depends on !BR2_m68k_cf
Giulio, do we have a BR2_TOOLCHAIN_HAS_..._BUG for this? Are other
packages affected by this? I see quite a few BR2_m68k_cf conditionals
sprinkled all over the places in Buildroot.
> + depends on BR2_INSTALL_LIBSTDCPP
I've added a dependency on gcc >= 4.8, because this package uses C++11.
I have verified it builds fine with GCC 4.8.
Applied with this tweak.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-30 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 20:04 [Buildroot] [PATCH 1/7] package/libde265: new package Bernd Kuhls
2023-07-08 20:04 ` [Buildroot] [PATCH 2/7] package/libheif: " Bernd Kuhls
2023-07-30 10:26 ` Thomas Petazzoni via buildroot [this message]
2023-07-30 10:56 ` Giulio Benetti
2023-07-30 11:25 ` Thomas Petazzoni via buildroot
2023-07-08 20:04 ` [Buildroot] [PATCH 3/7] package/gd: add optional support for libheif Bernd Kuhls
2023-07-30 10:27 ` Thomas Petazzoni via buildroot
2023-07-08 20:04 ` [Buildroot] [PATCH 4/7] package/imagemagick: " Bernd Kuhls
2023-07-30 10:27 ` Thomas Petazzoni via buildroot
2023-07-08 20:04 ` [Buildroot] [PATCH 5/7] package/libvips: " Bernd Kuhls
2023-07-30 10:27 ` Thomas Petazzoni via buildroot
2023-07-08 20:04 ` [Buildroot] [PATCH 6/7] package/kodi-imagedecoder-heif: new package Bernd Kuhls
2023-07-30 10:33 ` Thomas Petazzoni via buildroot
2023-07-08 20:04 ` [Buildroot] [PATCH 7/7] package/kodi-imagedecoder-raw: " Bernd Kuhls
2023-07-30 10:35 ` Thomas Petazzoni via buildroot
2023-07-30 10:24 ` [Buildroot] [PATCH 1/7] package/libde265: " Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230730122650.5592af4b@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=giulio.benetti@micronovasrl.com \
--cc=pieter.degendt@gmail.com \
--cc=s.martin49@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox