From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Robert Marko <robimarko@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/mhz: add new package
Date: Mon, 31 Jul 2023 14:51:53 +0200 [thread overview]
Message-ID: <20230731145153.638a3898@windsurf> (raw)
In-Reply-To: <87zg3c1d1e.fsf@tarshish>
On Mon, 31 Jul 2023 15:24:14 +0300
Baruch Siach <baruch@tkos.co.il> wrote:
> > +define MHZ_BUILD_CMDS
> > + $(TARGET_MAKE_ENV) $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS) $(TARGET_LDFLAGS)" -C $(@D)
>
> Are you sure you need TARGET_LDFLAGS here?
What about:
$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
This will also pass LDFLAGS, which is used by the upstream Makefile.
Thoams
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-31 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 12:20 [Buildroot] [PATCH v2] package/mhz: add new package Robert Marko
2023-07-31 12:24 ` Baruch Siach via buildroot
2023-07-31 12:51 ` Thomas Petazzoni via buildroot [this message]
2023-07-31 12:49 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731145153.638a3898@windsurf \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=robimarko@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox