From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Neal Frager via buildroot <buildroot@buildroot.org>
Cc: luca.ceresoli@bootlin.com, michal.simek@amd.com,
Neal Frager <neal.frager@amd.com>
Subject: Re: [Buildroot] [PATCH v1 1/1] board/versal: clean shellcheck issues
Date: Tue, 1 Aug 2023 23:20:23 +0200 [thread overview]
Message-ID: <20230801232023.50086a5f@windsurf> (raw)
In-Reply-To: <20230801100204.3111852-1-neal.frager@amd.com>
On Tue, 1 Aug 2023 11:02:04 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:
> mkdir -p "${BINARIES_DIR}"
> cat <<-__HEADER_EOF > "${BINARIES_DIR}/bootgen.bif"
> the_ROM_image:
> {
> image {
> - { type=bootimage, file=${BINARIES_DIR}/${BOARD_NAME}_vpl_gen_fixed.pdi }
> - { type=bootloader, file=${BINARIES_DIR}/${BOARD_NAME}_plm.elf }
> - { core=psm, file=${BINARIES_DIR}/${BOARD_NAME}_psmfw.elf }
> + { type=bootimage, file="${BINARIES_DIR}/${BOARD_NAME}_vpl_gen_fixed.pdi" }
> + { type=bootloader, file="${BINARIES_DIR}/${BOARD_NAME}_plm.elf" }
> + { core=psm, file="${BINARIES_DIR}/${BOARD_NAME}_psmfw.elf" }
Is it OK for bootgen.bif to contain double quotes around the file paths?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-01 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 10:02 [Buildroot] [PATCH v1 1/1] board/versal: clean shellcheck issues Neal Frager via buildroot
2023-08-01 21:20 ` Thomas Petazzoni via buildroot [this message]
2023-08-02 4:04 ` Frager, Neal via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801232023.50086a5f@windsurf \
--to=buildroot@buildroot.org \
--cc=luca.ceresoli@bootlin.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox