From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: buildroot@buildroot.org
Cc: Norbert Lange <nolange79@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Sen Hastings <sen@phobosdpl.com>
Subject: [Buildroot] [PATCH 2/2] package/systemd: fix wrong variable name in comment
Date: Thu, 3 Aug 2023 09:37:04 +0200 [thread overview]
Message-ID: <20230803073704.1379495-2-luca.ceresoli@bootlin.com> (raw)
In-Reply-To: <20230803073704.1379495-1-luca.ceresoli@bootlin.com>
There is no such thing as a BR2_TARGET_GENERIC_TTY_PATH variable. The
comment here should mention BR2_TARGET_GENERIC_GETTY_PORT instead.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
package/systemd/systemd.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
index 86b1715076a9..c8a83ae32f7f 100644
--- a/package/systemd/systemd.mk
+++ b/package/systemd/systemd.mk
@@ -674,15 +674,15 @@ ifneq ($(call qstrip,$(BR2_TARGET_GENERIC_GETTY_PORT)),)
# Systemd defaults to enabling getty@tty1.service
#
# What we want to do
-# * Enable a getty on $BR2_TARGET_GENERIC_TTY_PATH
+# * Enable a getty on $BR2_TARGET_GENERIC_GETTY_PORT
# * Set the baudrate for all units according to BR2_TARGET_GENERIC_GETTY_BAUDRATE
# * Always enable a getty on the console using systemd-getty-generator
# (backward compatibility with previous releases of buildroot)
#
# What we do
# * disable getty@tty1 (enabled by upstream systemd)
-# * enable getty@xxx if $BR2_TARGET_GENERIC_TTY_PATH is a tty
-# * enable serial-getty@xxx for other $BR2_TARGET_GENERIC_TTY_PATH
+# * enable getty@xxx if $BR2_TARGET_GENERIC_GETTY_PORT is a tty
+# * enable serial-getty@xxx for other $BR2_TARGET_GENERIC_GETTY_PORT
# * rewrite baudrates if a baudrate is provided
define SYSTEMD_INSTALL_SERVICE_TTY
mkdir -p $(TARGET_DIR)/usr/lib/systemd/system/getty@.service.d; \
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-03 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 7:37 [Buildroot] [PATCH 1/2] package/systemd: fix typos in comments Luca Ceresoli via buildroot
2023-08-03 7:37 ` Luca Ceresoli via buildroot [this message]
2023-08-31 11:10 ` [Buildroot] [PATCH 2/2] package/systemd: fix wrong variable name in comment Peter Korsgaard
2023-08-03 19:12 ` [Buildroot] [PATCH 1/2] package/systemd: fix typos in comments Yann E. MORIN
2023-08-31 11:10 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803073704.1379495-2-luca.ceresoli@bootlin.com \
--to=buildroot@buildroot.org \
--cc=luca.ceresoli@bootlin.com \
--cc=nolange79@gmail.com \
--cc=sen@phobosdpl.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox