From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Angelo Compagnucci <angelo@amarulasolutions.com>,
linux-amarula@amarulasolutions.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/arp-scan: don't install package data
Date: Fri, 4 Aug 2023 19:21:13 +0200 [thread overview]
Message-ID: <20230804172113.GQ421096@scaer> (raw)
In-Reply-To: <20230804160258.3918831-1-dario.binacchi@amarulasolutions.com>
Dario, All,
On 2023-08-04 18:02 +0200, Dario Binacchi spake thusly:
> The patch only installs the executables (less than 100kb) saving 1.4Mb
> of rootfs data.
>
> The list of what is no longer being installed:
> - arp-fingerprint.1 -> /usr/share/man/man1
> - arp-scan.1 -> /usr/share/man/man1
> - get-oui.1 -> /usr/share/man/man1
> - ieee-oui.txt -> /usr/share/arp-scan
> - mac-vendor.txt -> /etc/arp-scan
> - mac-vendor.5 -> /usr/share/man/man5
The man stuff will get removed automatically by Buildroot in the
target-finalize step, so that's not a concern that they get installed.
Plus see below...
>
> Cc: Angelo Compagnucci <angelo@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> package/arp-scan/arp-scan.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/arp-scan/arp-scan.mk b/package/arp-scan/arp-scan.mk
> index 89644be9d3ef..1c1bd34882ea 100644
> --- a/package/arp-scan/arp-scan.mk
> +++ b/package/arp-scan/arp-scan.mk
> @@ -23,4 +23,6 @@ else
> ARP_SCAN_CONF_OPTS += --without-libcap
> endif
>
> +ARP_SCAN_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install-exec
I think we want an option that makes the installation of that data
optional. Since that was installed so far, the option should default to
'y' for legacy purposes:
config BR2_PACKAGE_ARP_SCAN_DATA
bool "install data (OUI)"
default y # legacy
Regards,
Yann E. MORIN.
> $(eval $(autotools-package))
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-04 17:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 16:02 [Buildroot] [PATCH 1/1] package/arp-scan: don't install package data Dario Binacchi
2023-08-04 17:21 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804172113.GQ421096@scaer \
--to=yann.morin.1998@free.fr \
--cc=angelo@amarulasolutions.com \
--cc=buildroot@buildroot.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox