Re: [Buildroot] [PATCH 1/1] package/pkg-generic: handle host-php as an extract dependency

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Bernd, All,

On 2023-08-04 14:35 +0200, Thomas Petazzoni via buildroot spake thusly:
> On Fri,  4 Aug 2023 08:23:07 +0200
> Bernd Kuhls <bernd@kuhls.net> wrote:
> > Fixes:
> > http://autobuild.buildroot.net/results/506/50658c50fde8145fac320e3b17004e98c78c6c4d/
> > 
> > Although composer has host-php as build dependency, in the case of
> > BR2_PER_PACKAGE_DIRECTORIES=y host-php was not built during extract stage
> > of the composer package.
> > 
> > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> 
> Thanks for noticing this. I indeed completely overlooked that when
> reviewing/merging the composer patch. However, there is one thing that
> I believe isn't ideal in your proposal, indeed it's kind of "half-way"
> through.
> 
> You handle part of the problem in package/pkg-utils.mk, as if .phar
> extraction was supported in the generic way in the package
> infrastructure, but that isn't the case: it only works with the special
> _EXTRACT_CMDS defined in composer.mk. So this .phar extraction would
> not work for any other package.
> 
> So instead of your change in package/pkg-utils.mk, can you do:
> 
> HOST_COMPOSER_EXTRACT_DEPENDENCIES = $(BR2_PHP_HOST_DEPENDENCY)
> 
> in composer.mk ? This would make the entire handling of .phar
> extraction a problem of composer.mk.
> 
> Of course, should we progressively have more and more of these, we
> could look at making this generic. But right now, let's handle this as
> a composer.mk specific concern.
> 
> What do you think?

I agree that we do not want to introduce it in the generic infra for
now, until we have at least a few packages that need it.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot