From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Alistair Francis <alistair23@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/2] package/libopenssl: Copy the crypto include files
Date: Sun, 6 Aug 2023 15:49:06 +0200 [thread overview]
Message-ID: <20230806154906.03f6a549@windsurf> (raw)
In-Reply-To: <20230724014832.2207166-1-alistair.francis@wdc.com>
On Mon, 24 Jul 2023 11:48:31 +1000
Alistair Francis <alistair23@gmail.com> wrote:
> diff --git a/package/libopenssl/libopenssl.mk b/package/libopenssl/libopenssl.mk
> index 06eac8f3d9..c66a842cdf 100644
> --- a/package/libopenssl/libopenssl.mk
> +++ b/package/libopenssl/libopenssl.mk
> @@ -126,6 +126,10 @@ endef
>
> define LIBOPENSSL_INSTALL_STAGING_CMDS
> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) install
> + mkdir -p $(STAGING_DIR)/usr/include/crypto
> + $(INSTALL) -m 644 $(@D)/include/crypto/* $(STAGING_DIR)/usr/include/crypto/
> + mkdir -p $(STAGING_DIR)/usr/include/internal
> + $(INSTALL) -m 644 $(@D)/include/internal/* $(STAGING_DIR)/usr/include/internal/
I'm still quite concerned about this. Why the heck does libspdm require
the internal/private headers of OpenSSL, and no other package needs
that? It seems very odd, and potentially very wrong. One can assume
such internal headers expose internal APIs that don't have the same
backward compatibility guarantees as public APIs.
What makes libspdm so special? Is there any potential side effect of
exposing those OpenSSL private/internal headers to the wider world, as
your patch does?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-06 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 1:48 [Buildroot] [PATCH v2 1/2] package/libopenssl: Copy the crypto include files Alistair Francis
2023-07-24 1:48 ` [Buildroot] [PATCH v2 2/2] package/libspdm: Initial commit Alistair Francis
2023-08-06 13:56 ` Thomas Petazzoni via buildroot
2023-08-06 13:49 ` Thomas Petazzoni via buildroot [this message]
2023-08-11 20:28 ` [Buildroot] [PATCH v2 1/2] package/libopenssl: Copy the crypto include files Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230806154906.03f6a549@windsurf \
--to=buildroot@buildroot.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=s.martin49@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox