From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mpg123: fix linking error
Date: Mon, 7 Aug 2023 22:09:24 +0200 [thread overview]
Message-ID: <20230807220924.6aeacd56@windsurf> (raw)
In-Reply-To: <ZND9hxOZvMoUHrgQ@waldemar-brodkorb.de>
Hello Waldemar,
On Mon, 7 Aug 2023 16:19:51 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> Fixes following build errors:
> http://autobuild.buildroot.net/?reason=mpg123-1.31.3
Should be a pointer to a specific build issue, because
http://autobuild.buildroot.net/?reason=mpg123-1.31.3 points to several
issues, and in 5 years when we will look at this, we will no longer
know which issue it refers to.
Also, it should be just "Fixes:"
Finally, and probably even more importantly: we really, really, really
want an explanation of since when the problem has appeared, so that we
know if this commit needs to be backported to a stable branch or not.
Could you do this research and submit an updated patch?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-07 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 14:19 [Buildroot] [PATCH] package/mpg123: fix linking error Waldemar Brodkorb
2023-08-07 20:09 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807220924.6aeacd56@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox