From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/composer: needs host-php to extract phar files
Date: Tue, 8 Aug 2023 00:02:49 +0200 [thread overview]
Message-ID: <20230808000249.43e10184@windsurf> (raw)
In-Reply-To: <20230804155009.576919-1-bernd@kuhls.net>
Hello Bernd,
On Fri, 4 Aug 2023 17:50:09 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> Although composer has host-php as build dependency, in the case of
> BR2_PER_PACKAGE_DIRECTORIES=y host-php was not built during extract stage
> of the composer package.
It's not just BR2_PER_PACKAGE_DIRECTORIES=y that is broken. If you run
"make host-composer-extract", you'd get the same result, without
per-package directories. I've adjusted a bit the commit message.
> HOST_COMPOSER_DEPENDENCIES = host-php
> +HOST_COMPOSER_EXTRACT_DEPENDENCIES = host-php
Here I hesitated a bit because those dependencies (build and extract)
are now slightly redundant. However, it's true that we need host-php at
extract time, but also to use host-composer. But for host packages we
don't really have the concept of runtime dependency: the only way to
ensure a runtime dependency will be there at runtime is to make it a
build-time dependency, which is what we do here with
<pkg>_DEPENDENCIES. So I've kept it like you did, but I will certainly
be willing to hear arguments of others as I don't have a very strong
opinion there.
Applied to master with the tweaked commit log. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-07 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 15:50 [Buildroot] [PATCH v2 1/1] package/composer: needs host-php to extract phar files Bernd Kuhls
2023-08-07 22:02 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808000249.43e10184@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox