From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: Angelo Compagnucci <angelo@amarulasolutions.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
Asaf Kahlon <asafka7@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH/next vRFCv2 2/3] package/depot-tools: new package
Date: Tue, 8 Aug 2023 19:33:59 +0200 [thread overview]
Message-ID: <20230808193359.4e622af5@windsurf> (raw)
In-Reply-To: <20230808003527.1469175-3-adam.duskett@amarulasolutions.com>
On Mon, 7 Aug 2023 18:35:26 -0600
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> +DEPOT_TOOLS_VERSION = 4e87f5bfe244e903f712408ea68dc3c3a6fe2d00
> +DEPOT_TOOLS_SITE = https://chromium.googlesource.com/chromium/tools/depot_tools
> +DEPOT_TOOLS_SITE_METHOD = git
> +DEPOT_TOOLS_LICENSE = BSD-3-Clause
> +DEPOT_TOOLS_LICENSE_FILES = LICENSE
> +DEPOT_TOOLS_CPE_ID_VENDOR = google
> +HOST_DEPOT_TOOLS_DEPENDENCIES = \
> + host-python3 \
> + host-python-httplib2 \
> + host-python-pyparsing \
> + host-python-six
I was a bit surprised, because that doesn't match the dependencies in
the Config.in.host, but that's normal because not all host packages
have Config.in options.
> +define HOST_DEPOT_TOOLS_INSTALL_CMDS
> + mkdir -p $(HOST_DIR)/share/depot_tools
> + cp -dprf $(@D)/* $(HOST_DIR)/share/depot_tools/
I looked at whether there was a nicer way to install that. But in fact,
it's just a big mess of random tools, so OK installing to some random
folder in $(HOST_DIR)/share is probably the "right" thing.
> +# Helper wrapper to make using gclient easier.
> +DEPOT_TOOLS_GCLIENT=\
Minor nit: spaces around = sign.
> + PATH=$(BR_PATH):$(HOST_DIR)/share/depot_tools \
> + DEPOT_TOOLS_UPDATE=0 \
> + $(HOST_DIR)/share/depot_tools/gclient.py
Otherwise, looks good to me.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-08 17:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 0:35 [Buildroot] [PATCH/next vRFCv2 0/3] Initial flutter packages Adam Duskett
2023-08-08 0:35 ` [Buildroot] [PATCH/next vRFCv2 1/3] package/python-httplib2: add host variant Adam Duskett
2023-08-08 0:35 ` [Buildroot] [PATCH/next vRFCv2 2/3] package/depot-tools: new package Adam Duskett
2023-08-08 17:33 ` Thomas Petazzoni via buildroot [this message]
2023-08-08 0:35 ` [Buildroot] [PATCH/next vRFCv2 3/3] package/flutter-engine: " Adam Duskett
2023-08-08 17:56 ` Thomas Petazzoni via buildroot
2023-08-09 20:22 ` Yann E. MORIN
2023-08-09 20:55 ` Thomas Petazzoni via buildroot
2023-08-08 19:37 ` [Buildroot] [PATCH/next vRFCv2 0/3] Initial flutter packages Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808193359.4e622af5@windsurf \
--to=buildroot@buildroot.org \
--cc=adam.duskett@amarulasolutions.com \
--cc=angelo@amarulasolutions.com \
--cc=asafka7@gmail.com \
--cc=michael@amarulasolutions.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox