Re: [Buildroot] [PATCH v2 1/1] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Roberto,

Thanks, this looks mostly good, but I have a few comments/questions.

On Mon, 10 Jul 2023 23:21:47 +0200
Roberto Medina <robertoxmed@gmail.com> wrote:

> * Uses a more recent version of TF-A which solves the building issue for
>   this board.
> * Bump on U-Boot version that was used for this configuration.
> * Some minor fixes in the post-build.sh script using `shellcheck`.
> 
> Signed-off-by: Roberto Medina <robertoxmed@gmail.com>
> Tested-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
> ---
>  board/firefly/roc-rk3399-pc/extlinux.conf |  4 +++
>  board/firefly/roc-rk3399-pc/genimage.cfg  | 22 +++++++++++++
>  board/firefly/roc-rk3399-pc/post-build.sh |  5 +++
>  board/firefly/roc-rk3399-pc/readme.txt    | 40 +++++++++++++++++++++++
>  configs/roc_pc_rk3399_defconfig           | 38 +++++++++++++++++++++
>  5 files changed, 109 insertions(+)

Could you add an entry in the DEVELOPERS file referencing you as the
developer/maintainer for configs/roc_pc_rk3399_defconfig and
board/firefly/roc-rk3399-pc/ ?

> diff --git a/configs/roc_pc_rk3399_defconfig b/configs/roc_pc_rk3399_defconfig
> new file mode 100644
> index 0000000000..91574f1d61
> --- /dev/null
> +++ b/configs/roc_pc_rk3399_defconfig
> @@ -0,0 +1,38 @@
> +BR2_aarch64=y
> +BR2_cortex_a72_a53=y
> +BR2_BINUTILS_VERSION_2_40_X=y

Why are you forcing binutils 2.40 here? Any reason? This is why I
didn't apply, because I don't understand if there's a solid reason for
you to do that.

> +BR2_TARGET_GENERIC_HOSTNAME="roc-rk3399-pc"
> +BR2_TARGET_GENERIC_ISSUE="Welcome to ROC-RK3399-PC!"
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/firefly/roc-rk3399-pc/post-build.sh"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/firefly/roc-rk3399-pc/genimage.cfg"
> +BR2_LINUX_KERNEL=y

You need to set a fixed version of the Linux kernel.

> +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="rockchip/rk3399-roc-pc"
> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="240M"

Why this custom size rather than leaving the default?

> +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.9.0"

Could you use v2.9 instead? It's pointing to the same commit, but it
will make sure that our patch
boot/arm-trusted-firmware/v2.9/0001-build-tools-avoid-unnecessary-link.patch
gets applied.

> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="rk3399"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES=""
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_ARM32_TOOLCHAIN=y
> +BR2_TARGET_UBOOT=y

You need to set a fixed version of U-Boot.

> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="roc-pc-rk3399"
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
> +BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
> +BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
> +BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
> +BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
> +BR2_TARGET_UBOOT_SPL=y
> +BR2_TARGET_UBOOT_SPL_NAME="idbloader.img"
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y

Not sure here why BR2_PACKAGE_HOST_UBOOT_TOOLS=y is needed?

Could you rework your patch to address those small aspects and send an
updated version?

Thanks a lot!

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot