Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Flávio Tapajós" <flavio.tapajos@newtesc.com.br>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] configs: asus_tinker-s_rk3288: new config for the "S" variant of the Tinker Board
Date: Tue, 8 Aug 2023 23:14:21 +0200	[thread overview]
Message-ID: <20230808231421.7f94494d@windsurf> (raw)
In-Reply-To: <20230710162914.27264-2-flavio.tapajos@newtesc.com.br>

Hello Flávio,

Thanks for your contribution!

On Mon, 10 Jul 2023 13:29:15 -0300
Flávio Tapajós <flavio.tapajos@newtesc.com.br> wrote:

> This commit duplicates the asus_tinker_rk3288_defconfig changing:
> 
>   - BR2_LINUX_KERNEL_INTREE_DTS_NAME to rk3288-tinker-s
>   - BR2_TARGET_UBOOT_BOARD_DEFCONFIG to tinker-s-rk3288
>   - extlinux.conf devicetree to /boot/rk3288-tinker-s.dtb
>   - root device format to <major>:<minor> in order to prevent the kernel to mount rootfs
>     from the wrong device
>   - Add Flávio Tapajós for configs/asus_tinker-s_rk3288_defconfig and for
>     configs/asus_tinker-s_rk3288_defconfig and for board/asus/tinker-s
> 
> Signed-off-by: Flávio Tapajós <flavio.tapajos@newtesc.com.br>
> ---
>  DEVELOPERS                             |  4 +++
>  board/asus/tinker-s/extlinux.conf      |  4 +++
>  board/asus/tinker-s/post-build.sh      |  9 +++++
>  board/asus/tinker-s/readme.txt         | 43 ++++++++++++++++++++++++
>  configs/asus_tinker-s_rk3288_defconfig | 46 ++++++++++++++++++++++++++
>  5 files changed, 106 insertions(+)
>  create mode 100644 board/asus/tinker-s/extlinux.conf
>  create mode 100755 board/asus/tinker-s/post-build.sh
>  create mode 100644 board/asus/tinker-s/readme.txt
>  create mode 100644 configs/asus_tinker-s_rk3288_defconfig

Applied to next, thanks.

I think it would be nice if you (for tinker-s) and Giulio (in Cc, for
tinker) would change the defconfig to generate and use a kernel zImage
instead of uImage. uImage is kind of deprecated, and it doesn't make
much sense to use that anymore.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-08-08 21:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 16:29 [Buildroot] [PATCH 1/1] configs: asus_tinker-s_rk3288: new config for the "S" variant of the Tinker Board Flávio Tapajós
2023-08-08 21:14 ` Thomas Petazzoni via buildroot [this message]
2023-08-10 22:01   ` [Buildroot] [PATCH] configs/asus_tinker_rk3288_defconfig: switch to zImage and bump Linux to 6.1.44, U-Boot to 2023.07 Giulio Benetti
2023-08-10 22:07     ` Giulio Benetti
2023-08-10 22:10       ` [Buildroot] [PATCH v2] " Giulio Benetti
2024-02-06 23:00         ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808231421.7f94494d@windsurf \
    --to=buildroot@buildroot.org \
    --cc=flavio.tapajos@newtesc.com.br \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=jagan@amarulasolutions.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox