Re: [Buildroot] [PATCH 0/2] Fix Rock 5B build, broken by gcc 12 warnings

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Kilian Zinnecker <kilian.zinnecker@mail.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 0/2] Fix Rock 5B build, broken by gcc 12 warnings
Date: Tue, 8 Aug 2023 23:19:13 +0200	[thread overview]
Message-ID: <20230808231913.1d0a98e1@windsurf> (raw)
In-Reply-To: <1860848.tdWV9SEqCh@kilian-aisec>

On Tue, 08 Aug 2023 22:44:04 +0200
Kilian Zinnecker <kilian.zinnecker@mail.de> wrote:

> > I'm not sure to understand the reasoning for the second patch. Does it
> > fix all gcc 12.x issues or not? If not, what is the motivation for this
> > second patch?  
> 
> No, the second patch does not fix all gcc 12.x issues. It only fixes two of 
> them. I think that fixing two of the warnings for now still is a plus.

Nah, it doesn't make sense to fix them because if there are remaining
issues, we can't switch to gcc 12.x anyway, and those those two patches
are basically useless dead code.

> Thanks for the info, I actually would not have known this! I think that the 
> best way is to ask the maintainers of the Radxa custom kernel whether they may 
> fix the remaining issues, so that the custom kernel compiles with gcc 12.x. I 
> intend to do so.

ACK.

> I think both patches should be applied. However, the first patch alone should 
> already cause to fix the build itself. (Tbh. I did not test it though.)

Would be good to test before sending patches :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot