Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/rauc-hawkbit-updater: new package
Date: Thu, 10 Aug 2023 23:33:28 +0200	[thread overview]
Message-ID: <20230810233328.5dbf77a3@windsurf> (raw)
In-Reply-To: <20230208185516.858096-1-colin.foster@in-advantage.com>

Hello Colin,

On Wed,  8 Feb 2023 10:55:16 -0800
Colin Foster <colin.foster@in-advantage.com> wrote:

> Add useful tool for bridging RAUC with the Hawkbit API.
> 
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>

Sorry for the very slow feedback, but I have finally reviewed... and
applied your patch! See below some comments.

> ---
>  package/Config.in                                 |  1 +
>  package/rauc-hawkbit-updater/Config.in            | 14 ++++++++++++++
>  .../rauc-hawkbit-updater.hash                     |  3 +++
>  .../rauc-hawkbit-updater/rauc-hawkbit-updater.mk  | 15 +++++++++++++++
>  4 files changed, 33 insertions(+)

Entry in the DEVELOPERS file was missing.


> diff --git a/package/rauc-hawkbit-updater/Config.in b/package/rauc-hawkbit-updater/Config.in
> new file mode 100644
> index 0000000000..bd7b8d7cf5
> --- /dev/null
> +++ b/package/rauc-hawkbit-updater/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_RAUC_HAWKBIT_UPDATER
> +    bool "rauc-hawkbit-updater"
> +    depends on BR2_PACKAGE_RAUC
> +    depends on BR2_PACKAGE_JSON_GLIB

We want those dependencies to be using "select" instead. Also the
dependency on libcurl was missing.

The indentation of the file was also not correct (we use one tab for
depends on/bool/select), and one tab + 2 spaces for the help text. This
is checked by running "make check-package".

Overall, Config.in now looks like this:

+config BR2_PACKAGE_RAUC_HAWKBIT_UPDATER
+       bool "rauc-hawkbit-updater"
+       depends on BR2_TOOLCHAIN_HAS_THREADS # rauc, json-glib
+       depends on BR2_USE_MMU # rauc, json-glib
+       depends on BR2_USE_WCHAR # rauc, json-glib
+       select BR2_PACKAGE_JSON_GLIB
+       select BR2_PACKAGE_LIBCURL
+       # runtime
+       select BR2_PACKAGE_RAUC
+       help
+         rauc-hawkbit-updater is a link between Pengutronix RAUC and
+         the Eclipse Hawkbit API. Hawkbit can communicate to remote
+         update servers, and use the d-bus interface to trigger
+         updates from RAUC.
+
+         http://rauc.io/
+
+comment "rauc-hawkbit-updater needs a toolchain w/ wchar, threads"
+       depends on BR2_USE_MMU
+       depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS


> diff --git a/package/rauc-hawkbit-updater/rauc-hawkbit-updater.hash b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.hash
> new file mode 100644
> index 0000000000..c65ead3784
> --- /dev/null
> +++ b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  42318e96a464e6c716edb45c48bd3ec3b874462973db902fbe099a395e4acb4b  rauc-hawkbit-updater-1.3.tar.xz
> +sha256  041234c81fd6fe6c531ea1a886b9e740b9ee06759d1a910a14edbd06f4aa62c7  LICENSE
> diff --git a/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
> new file mode 100644
> index 0000000000..5a74181361
> --- /dev/null
> +++ b/package/rauc-hawkbit-updater/rauc-hawkbit-updater.mk
> @@ -0,0 +1,15 @@
> +###############################################################################
> +#
> +# rauc-hawkbit-updater
> +#
> +###############################################################################

This comment header was also causing some "make check-package" warnings
due to an incorrect number of # signs.

> +
> +RAUC_HAWKBIT_UPDATER_VERSION = 1.3
> +RAUC_HAWKBIT_UPDATER_SITE = https://github.com/rauc/rauc-hawkbit-updater/releases/download/v$(RAUC_HAWKBIT_UPDATER_VERSION)
> +RAUC_HAWKBIT_UPDATER_SOURCE = rauc-hawkbit-updater-$(RAUC_HAWKBIT_UPDATER_VERSION).tar.xz
> +RAUC_HAWKBIT_UPDATER_LICENSE = LGPL-2.1
> +RAUC_HAWKBIT_UPDATER_LICENSE_FILES = LICENSE
> +RAUC_HAWKBIT_UPDATER_CPE_ID_VENDOR = pengutronix
> +RAUC_HAWKBIT_UPDATER_DEPENDENCIES = json-glib

libcurl was missing here

Applied to next with those different changes. Thanks for your
contribution, and again sorry for the very late feedback.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2023-08-10 21:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 18:55 [Buildroot] [PATCH] package/rauc-hawkbit-updater: new package Colin Foster
2023-02-21 21:36 ` Colin Foster
2023-02-23 19:18   ` Arnout Vandecappelle
2023-08-10 21:33 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230810233328.5dbf77a3@windsurf \
    --to=buildroot@buildroot.org \
    --cc=colin.foster@in-advantage.com \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox