Re: [Buildroot] [PATCH v1] package/fft_eval: new package

From: Peter Seiderer <ps.report@gmx.net>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1] package/fft_eval: new package
Date: Fri, 11 Aug 2023 21:22:20 +0200	[thread overview]
Message-ID: <20230811212220.52d4ffb9@gmx.net> (raw)
In-Reply-To: <20230811000738.0c613b1e@windsurf>

Hello Thomas,

On Fri, 11 Aug 2023 00:07:38 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello Peter,
>
> On Sat, 11 Feb 2023 17:34:22 +0100
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> I have finally reviewed your patch and applied to next, with some changes. See below.
>
> > ---
> >  package/Config.in              |  1 +
> >  package/fft_eval/Config.in     | 13 ++++++++++++
> >  package/fft_eval/fft_eval.hash |  5 +++++
> >  package/fft_eval/fft_eval.mk   | 36 ++++++++++++++++++++++++++++++++++
> >  4 files changed, 55 insertions(+)
> >  create mode 100644 package/fft_eval/Config.in
> >  create mode 100644 package/fft_eval/fft_eval.hash
> >  create mode 100644 package/fft_eval/fft_eval.mk
>
> I've renamed from fft_eval to fft-eval, as we prefer - as the separator
> in package names these days.

O.k.

>
> I've added an entry in the DEVELOPERS file as well.

O.k.

>
>
> > diff --git a/package/fft_eval/Config.in b/package/fft_eval/Config.in
> > new file mode 100644
> > index 0000000000..4b6aa9b388
> > --- /dev/null
> > +++ b/package/fft_eval/Config.in
> > @@ -0,0 +1,13 @@
> > +config BR2_PACKAGE_FFT_EVAL
> > +	bool "fft_eval"
> > +	help
> > +	  Pogram to aid open source spectrum analyzer development
>
>           ^^ Program
>
> > +	  for Qualcomm/Atheros AR92xx and AR93xx based chipsets.
> > +
> > +	  It visualizes the FFT data reported by the chips to help
> > +	  interpreting and understanding the data.
> > +
> > +	  Enabel sdl2 and sdl2_ttf for the graphic output tool
>
>           ^^ Enable

Thanks for fixing my typos ;-)

>
> > +FFT_EVAL_VERSION = 6a82b383ce79afc4c1ba26ffcf34b15d3e95894b
> > +FFT_EVAL_SITE = $(call github,simonwunderlich,FFT_eval,$(FFT_EVAL_VERSION))
> > +FFT_EVAL_LICENSE = CC0-1.0 (doc), GPL-2.0-only, OFL-1.1 (LiberationSans-Regular.ttf)
> > +FFT_EVAL_LICENSE_FILES = \
> > +	LICENSES/CC0-1.0.txt \
> > +	LICENSES/GPL-2.0-only.txt \
> > +	LICENSES/OFL-1.1.txt
> > +
> > +FFT_EVAL_CONV_OPTS = CONFIG_fft_eval_json=y
> > +FFT_EVAL_TARGETS = fft_eval_json
> > +
> > +ifeq ($(BR2_PACKAGE_SDL2)$(BR2_PACKAGE_SDL2_TTF),yy)
> > +FFT_EVAL_CONV_OPTS += CONFIG_fft_eval_sdl=y
> > +FFT_EVAL_DEPENDENCIES += sdl2 sdl2_ttf
> > +FFT_EVAL_TARGETS += fft_eval_sdl
> > +else
> > +FFT_EVAL_CONV_OPTS += CONFIG_fft_eval_sdl=n
> > +endif
> > +
> > +define FFT_EVAL_BUILD_CMDS
> > +	$(MAKE) $(TARGET_CONFIGURE_OPTS) CROSS=$(STAGING_DIR)/usr/bin/ $(FFT_EVAL_CONV_OPTS) -C $(@D) all
> > +endef
> > +
> > +define FFT_EVAL_INSTALL_TARGET_CMDS
> > +	for i in $(FFT_EVAL_TARGETS); do \
> > +		$(INSTALL) -D -m 0755 $(@D)/$$i $(TARGET_DIR)/usr/bin || exit 1; \
> > +	done
> > +endef
>
> I've use "make install" instead of doing the manual installation here.

Looks nicer..., but now the variable FFT_EVAL_TARGETS is unused?

Regards,
Peter

>
> Applied to next with those changes. Thanks!
>
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot