From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D981DC0015E for ; Sat, 12 Aug 2023 14:24:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8F008606F2; Sat, 12 Aug 2023 14:24:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8F008606F2 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i_b82A_ibEX6; Sat, 12 Aug 2023 14:24:09 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 8A09B60B43; Sat, 12 Aug 2023 14:24:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8A09B60B43 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 2FB9F1BF344 for ; Sat, 12 Aug 2023 14:24:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 143E281C19 for ; Sat, 12 Aug 2023 14:24:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 143E281C19 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UAFaz-HfrqrP for ; Sat, 12 Aug 2023 14:24:06 +0000 (UTC) Received: from smtp4-g21.free.fr (smtp4-g21.free.fr [212.27.42.4]) by smtp1.osuosl.org (Postfix) with ESMTPS id A8A1E81BA9 for ; Sat, 12 Aug 2023 14:24:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A8A1E81BA9 Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8b44:b00:a00a:6044:1314:a80a]) (Authenticated sender: yann.morin.1998@free.fr) by smtp4-g21.free.fr (Postfix) with ESMTPSA id 1942B19F5AB; Sat, 12 Aug 2023 16:23:59 +0200 (CEST) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Sat, 12 Aug 2023 16:23:59 +0200 Date: Sat, 12 Aug 2023 16:23:59 +0200 From: "Yann E. MORIN" To: Baruch Siach Message-ID: <20230812142359.GM421096@scaer> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1691850242; bh=6ghJyppVM/WFtNhO6uVlGCs4sgKVATzZQMxF/xU/Bfc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ErUTIVmI92M+Aekj+VjPXuaQv6kFZPZa/1KfLH2hNvmk5nIMdlgAI/BjJwX6gSs0C nrnLYgUVrmI50DipRKWYG+CHJq5hB58d95knMRVWJ+nmoH4rVVUrCV7PtPGnDTqXx1 Wc+hkQPbSMmOYg928laIQy9MYr9T7ugUcjak8SgpLV9/tEKWlv2CnMVD4AY+L4mQpS haeakoTZAn4kVFvuJU1RFvgy3oCS4Z+rd6R5kBdn2jLqMEenQHk3GyijNfzF01YsZy JM7ob/6W8vaZvwAzvbb2uY+P/8CovHiR0ep3/8CSx6vjVLHgQqcMCuf77ABdLd1lX6 RbtnyOMPIdCqw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=ErUTIVmI Subject: Re: [Buildroot] [PATCH] boot/mv-ddr-marvell: fix build with gcc 12 X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@busybox.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Baruch, All, On 2023-08-11 11:48 +0300, Baruch Siach via buildroot spake thusly: > gcc 12 added a warning that triggers on access to low addresses. Add a > patch to allow access since this is normal for low level code. > > Rebase our existing patch on top. While at it, add also a proper > Upstream tag. > > Fixes: > https://gitlab.com/buildroot.org/buildroot/-/jobs/4795673785 > > Signed-off-by: Baruch Siach Applied to master, thanks. Regards, Yann E. MORIN. > --- > .checkpackageignore | 1 - > ...-access-to-low-addresses-with-gcc-12.patch | 49 +++++++++++++++++++ > ...2-Makefile-disable-stack-protection.patch} | 11 ++--- > 3 files changed, 54 insertions(+), 7 deletions(-) > create mode 100644 boot/mv-ddr-marvell/0001-Allow-access-to-low-addresses-with-gcc-12.patch > rename boot/mv-ddr-marvell/{0001-Makefile-disable-stack-protection.patch => 0002-Makefile-disable-stack-protection.patch} (80%) > > diff --git a/.checkpackageignore b/.checkpackageignore > index 627b0cc92b52..dfc1ba900194 100644 > --- a/.checkpackageignore > +++ b/.checkpackageignore > @@ -108,7 +108,6 @@ boot/at91dataflashboot/0001-do-not-install.patch Upstream > boot/at91dataflashboot/0002-eabi-fixes.patch Upstream > boot/grub2/0001-Makefile-Make-grub_fstest.pp-depend-on-config-util.h.patch Upstream > boot/grub2/0002-grub-mkconfig-Restore-umask-for-the-grub.cfg.patch Upstream > -boot/mv-ddr-marvell/0001-Makefile-disable-stack-protection.patch Upstream > boot/optee-os/3.13.0/0001-core-zlib-fix-build-warning-when-_LFS64_LARGEFILE-is.patch Upstream > boot/syslinux/0001-bios-Fix-alignment-change-with-gcc-5.patch Upstream > boot/syslinux/0002-Disable-PIE-to-avoid-FTBFS-on-amd64.patch Upstream > diff --git a/boot/mv-ddr-marvell/0001-Allow-access-to-low-addresses-with-gcc-12.patch b/boot/mv-ddr-marvell/0001-Allow-access-to-low-addresses-with-gcc-12.patch > new file mode 100644 > index 000000000000..5a623f28f95d > --- /dev/null > +++ b/boot/mv-ddr-marvell/0001-Allow-access-to-low-addresses-with-gcc-12.patch > @@ -0,0 +1,49 @@ > +From 4796a1eacc6a5ccb623e7d2e46a5196f8335e496 Mon Sep 17 00:00:00 2001 > +From: Baruch Siach > +Date: Fri, 11 Aug 2023 11:19:49 +0300 > +Subject: [PATCH] Allow access to low addresses with gcc 12 > + > +gcc 12 added a warning that triggers on access to low addresses. Add a > +compile option that allows access to lower addresses. > + > +Add the 'cc_option' macro to avoid the compile option when the compiler > +does not support it. > + > +This fixes build with TF-A. TF-A added a similar fix in commit > +dea23e245fb89. > + > +See some more details in > +https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105523 > + > +Upstream: https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/pull/42 > +Signed-off-by: Baruch Siach > +--- > + Makefile | 5 +++++ > + 1 file changed, 5 insertions(+) > + > +diff --git a/Makefile b/Makefile > +index 3f0dd89a7381..045284c30cbc 100644 > +--- a/Makefile > ++++ b/Makefile > +@@ -108,6 +108,10 @@ MV_DDR_VER_CSRC = mv_ddr_build_message.c > + # create mv_ddr build message and version string source file > + $(shell $(MV_DDR_ROOT)/scripts/localversion.sh $(MV_DDR_ROOT) $(MV_DDR_VER_CSRC) 2> /dev/null) > + > ++define cc_option > ++ $(shell if $(CC) $(1) -c -x c /dev/null -o /dev/null >/dev/null 2>&1; then echo $(1); fi ) > ++endef > ++ > + # ****************** > + # U-BOOT SPL SUPPORT > + # ****************** > +@@ -331,6 +335,7 @@ OBJ_DIR ?= $(MV_DDR_ROOT) > + CFLAGS = -DMV_DDR_ATF -DCONFIG_DDR4 > + CFLAGS += -Wall -Werror -Os -ffreestanding -mlittle-endian -g -gdwarf-2 -nostdinc > + CFLAGS += -march=armv8-a -fpie > ++CFLAGS += $(call cc_option, --param=min-pagesize=0) > + > + # PLATFORM is set in ble/ble.mk > + ifneq ($(findstring a80x0,$(PLATFORM)),) > +-- > +2.40.1 > + > diff --git a/boot/mv-ddr-marvell/0001-Makefile-disable-stack-protection.patch b/boot/mv-ddr-marvell/0002-Makefile-disable-stack-protection.patch > similarity index 80% > rename from boot/mv-ddr-marvell/0001-Makefile-disable-stack-protection.patch > rename to boot/mv-ddr-marvell/0002-Makefile-disable-stack-protection.patch > index 62b1000727f8..626279eb4714 100644 > --- a/boot/mv-ddr-marvell/0001-Makefile-disable-stack-protection.patch > +++ b/boot/mv-ddr-marvell/0002-Makefile-disable-stack-protection.patch > @@ -10,25 +10,24 @@ routines. > The mv-ddr-marvell Makefile provides no way to add custom CFLAGS. Patch > Makefile to disable stack protection. > > +Upstream: not applicable; Buildroot specific > Signed-off-by: Baruch Siach > ---- > -Upstream status: not applicable; Buildroot specific > --- > Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile b/Makefile > -index 3f0dd89a7381..feae75cc16e4 100644 > +index 045284c30cbc..9641354bcf86 100644 > --- a/Makefile > +++ b/Makefile > -@@ -331,6 +331,7 @@ OBJ_DIR ?= $(MV_DDR_ROOT) > - CFLAGS = -DMV_DDR_ATF -DCONFIG_DDR4 > +@@ -336,6 +336,7 @@ CFLAGS = -DMV_DDR_ATF -DCONFIG_DDR4 > CFLAGS += -Wall -Werror -Os -ffreestanding -mlittle-endian -g -gdwarf-2 -nostdinc > CFLAGS += -march=armv8-a -fpie > + CFLAGS += $(call cc_option, --param=min-pagesize=0) > +CFLAGS += -fno-stack-protector > > # PLATFORM is set in ble/ble.mk > ifneq ($(findstring a80x0,$(PLATFORM)),) > -- > -2.35.1 > +2.40.1 > > -- > 2.40.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot