Re: [Buildroot] [PATCH 2/2] package/weston: introduce _SIMPLE_CLIENTS package option

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Julien, All,

On 2023-08-03 22:15 +0200, Julien Olivain spake thusly:
> commit "package/weston: fix the configuration of simple-clients"
> fixed the configuration of Weston simple-clients by always enabling all
> supported applications.
> 
> Since it is not desirable to always have all those applications
> installed on target, this commit introduces a new package Kconfig
> option to control this.
> 
> Since there is already a BR2_PACKAGE_WESTON_DEMO_CLIENTS option present,
> this commit also update the Kconfig "help" entries, to clarify the
> difference between those "demo clients" and "simple clients". Those
> clients groups are directly coming from the upstream package (and are
> directly mapped to Meson configure options).
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
[--SNIP--]
> diff --git a/package/weston/weston.mk b/package/weston/weston.mk
> index 5f8d915d5a..0974159a9f 100644
> --- a/package/weston/weston.mk
> +++ b/package/weston/weston.mk
> @@ -22,6 +22,7 @@ WESTON_CONF_OPTS = \
>  	-Dlauncher-libseat=true \
>  	-Dtools=calibrator,debug,info,terminal,touch-calibrator
>  
> +ifeq ($(BR2_PACKAGE_WESTON_SIMPLE_CLIENTS),y)
>  WESTON_SIMPLE_CLIENTS = \
>  	damage \
>  	dmabuf-egl \
> @@ -37,6 +38,9 @@ WESTON_SIMPLE_CLIENTS += dmabuf-v4l
>  endif
>  
>  WESTON_CONF_OPTS += -Dsimple-clients=$(subst $(space),$(comma),$(strip $(WESTON_SIMPLE_CLIENTS)))
> +else
> +WESTON_CONF_OPTS += -Dsimple-clients=
> +endif

I moved the assignment outisde the conditional block, Indeed, if
BR2_PACKAGE_WESTON_SIMPLE_CLIENTS is unset, WESTON_SIMPLE_CLIENTS will
not be set and thus wil be empty, which is as good an empty list as we
need. ;-)

Applied to next, thanks.

Regards,
Yann E. MORIN.

>  ifeq ($(BR2_PACKAGE_JPEG),y)
>  WESTON_CONF_OPTS += -Dimage-jpeg=true
> -- 
> 2.41.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot