From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Vincent Fazio <vfazio@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] support/scripts/gen-bootlin-toolchains: generate BR2_ARCH_NEEDS_GCC_AT_LEAST_X guard
Date: Sun, 13 Aug 2023 18:09:00 +0200 [thread overview]
Message-ID: <20230813160900.GA421096@scaer> (raw)
In-Reply-To: <20230813045912.10404-1-vfazio@gmail.com>
Vincent, All,
On 2023-08-12 23:59 -0500, Vincent Fazio spake thusly:
> Previously, gen-bootlin-toolchains did not add a `depends` guard to
> limit the available toolchains based on the minimum required GCC version
> for the user selected CPU tuning.
>
> Now, the proper BR2_ARCH_NEEDS_GCC_AT_LEAST_X guard will be added based
> on the version of GCC provided by the toolchain.
>
> Signed-off-by: Vincent Fazio <vfazio@gmail.com>
s for the other external toolchains, this is a fix, so I applied to
master.
I did regenerate the toolchains, after adding a litle temporary kludge
so that the latest Bootlin toolchain version was ignored.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> support/scripts/gen-bootlin-toolchains | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/support/scripts/gen-bootlin-toolchains b/support/scripts/gen-bootlin-toolchains
> index 23ebfbdce9..4344221213 100755
> --- a/support/scripts/gen-bootlin-toolchains
> +++ b/support/scripts/gen-bootlin-toolchains
> @@ -338,6 +338,8 @@ class Toolchain:
> m = re.match("^BR2_TOOLCHAIN_EXTERNAL_GCC_([0-9_]*)=y$", frag)
> assert m, "Cannot get gcc version for toolchain %s" % self.fname_prefix
> selects.append("BR2_TOOLCHAIN_GCC_AT_LEAST_%s" % m[1])
> + # respect the GCC requirement for the selected CPU/arch tuning
> + depends.append("!BR2_ARCH_NEEDS_GCC_AT_LEAST_%s" % str(int(m[1]) + 1))
>
> # kernel headers version
> if frag.startswith("BR2_TOOLCHAIN_EXTERNAL_HEADERS_"):
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-13 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 4:59 [Buildroot] [PATCH 1/1] support/scripts/gen-bootlin-toolchains: generate BR2_ARCH_NEEDS_GCC_AT_LEAST_X guard Vincent Fazio
2023-08-13 16:09 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230813160900.GA421096@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vfazio@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox