Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/perftest: fix unmet direct dependencies
Date: Mon, 14 Aug 2023 12:56:44 +0200	[thread overview]
Message-ID: <20230814105644.GB421096@scaer> (raw)
In-Reply-To: <ZNnU4wGoYvMTOSkQ@waldemar-brodkorb.de>

Waldemar, All,

On 2023-08-14 09:16 +0200, Waldemar Brodkorb spake thusly:
> rdma-core selects perftest and needs NPTL.
> Should be backported to stable branches, because the problem
> exist since the addition of the package.
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/00c/00ce19a1589c6028ee77c333ed9107e2c8c8d6de
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/perftest/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/perftest/Config.in b/package/perftest/Config.in
> index 25cd1a9b8d..0a4114015b 100644
> --- a/package/perftest/Config.in
> +++ b/package/perftest/Config.in
> @@ -20,7 +20,7 @@ config BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
>  config BR2_PACKAGE_PERFTEST
>  	bool "perftest"
>  	depends on BR2_PACKAGE_PERFTEST_ARCH_SUPPORTS
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # rdma-core

You also missed propagating the dependency on the kernel headers
version, so I've done that.

I also expanded the commit log to explain when the two issues were
introduced.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  	depends on !BR2_STATIC_LIBS # rdma-core
>  	# musl does not define sysconf(_SC_LEVEL1_DCACHE_LINESIZE)
>  	depends on !BR2_TOOLCHAIN_USES_MUSL
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-08-14 10:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14  7:16 [Buildroot] [PATCH] package/perftest: fix unmet direct dependencies Waldemar Brodkorb
2023-08-14 10:56 ` Yann E. MORIN [this message]
2023-09-12 18:18 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230814105644.GB421096@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=wbx@openadk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox