From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Markus Mayer <mmayer@broadcom.com>
Cc: Buildroot mailing list <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 2/2] Revert "package/util-linux: add missing autoreconf"
Date: Fri, 18 Aug 2023 07:47:37 +0200 [thread overview]
Message-ID: <20230818054737.GD1340200@scaer> (raw)
In-Reply-To: <20230818003124.3770152-3-mmayer@broadcom.com>
Markus, All,
On 2023-08-17 17:31 -0700, Markus Mayer via buildroot spake thusly:
> This reverts commit f3fab0defe8fa9e1d99e4a89ddb29776e3bdd7fd.
>
> With 0001-libmount-ifdef-statx-call.patch no longer required (due to the
> release of util-linux 2.39.2), we no longer need to run autoreconf.
The AUTORECONF=YES should have been dropped in the previous patch.
Indeed, the bump and associated removal of the patch is what means
autoreconf is not needed; it is all a semantically atomice change: bump,
drop patch, remove autoreconf.
Besides, a git-revert semantically means "the reverted commit was wrong
even at the time it was introduced". But here, using autoreconf was
correct when we introduced it, so it should not be "git-reverted".
No need to respin, the two commits can be squashed when applying.
Regards,
Yann E. MORIN.
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
> package/util-linux/util-linux.mk | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
> index 73eda5c17134..4a40d5afec85 100644
> --- a/package/util-linux/util-linux.mk
> +++ b/package/util-linux/util-linux.mk
> @@ -30,10 +30,6 @@ UTIL_LINUX_LICENSE_FILES = README.licensing \
> Documentation/licenses/COPYING.LGPL-2.1-or-later
>
> UTIL_LINUX_CPE_ID_VENDOR = kernel
> -
> -# 0001-libmount-ifdef-statx-call.patch
> -UTIL_LINUX_AUTORECONF = YES
> -
> UTIL_LINUX_INSTALL_STAGING = YES
> UTIL_LINUX_DEPENDENCIES = \
> host-pkgconf \
> --
> 2.40.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-18 5:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 0:31 [Buildroot] [PATCH 0/2] util-linux 2.39.2 Markus Mayer via buildroot
2023-08-18 0:31 ` [Buildroot] [PATCH 1/2] package/util-linux: bump version to 2.39.2 Markus Mayer via buildroot
2023-08-18 0:31 ` [Buildroot] [PATCH 2/2] Revert "package/util-linux: add missing autoreconf" Markus Mayer via buildroot
2023-08-18 5:47 ` Yann E. MORIN [this message]
2023-08-18 23:24 ` Markus Mayer via buildroot
2023-08-20 21:20 ` [Buildroot] [PATCH 0/2] util-linux 2.39.2 Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818054737.GD1340200@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=mmayer@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox