Re: [Buildroot] [PATCH/next v2 1/1] package/{gettext-gnu, libtextstyle}: bump to version 0.22

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Bernd, All,

On 2023-08-18 16:42 +0200, Bernd Kuhls spake thusly:
> Release notes:
> https://lists.gnu.org/archive/html/info-gnu/2020-07/msg00009.html
> https://lists.gnu.org/archive/html/info-gnu/2023-06/msg00003.html
> 
> Removed patch 0001, the patched file is not present in this release.
> Removed patch 0002 which was applied upstream.
> 
> Link libtextstyle.hash to gettext-gnu.hash.
> 
> Added comments about other files to be updated during version bumps.
> 
> Since upstream commit
> https://github.com/autotools-mirror/gettext/commit/785a89e5df994c2b242f082d60de89e2d520aa4a
> gettext-runtime is a build-dependency for gettext-tools so we add the
> needed HOST_GETTEXT_GNU_PRE_{CONFIGURE, BUILD}_HOOKS.

[--SNIP--]
> diff --git a/package/gettext-gnu/gettext-gnu.mk b/package/gettext-gnu/gettext-gnu.mk
> index 9a1eabd0df..67074e42bc 100644
> --- a/package/gettext-gnu/gettext-gnu.mk
> +++ b/package/gettext-gnu/gettext-gnu.mk
> @@ -4,8 +4,9 @@
>  #
>  ################################################################################
>  
> -# Please keep in sync with package/libtextstyle/libtextstyle.mk
> -GETTEXT_GNU_VERSION = 0.20.1
> +# Please keep in sync with package/libtextstyle/libtextstyle.mk and
> +# GETTEXT_TINY_ARCHIVE_VERSION in gettext-tiny/gettext-tiny.mk
> +GETTEXT_GNU_VERSION = 0.22

So we now have three files that must be kept in sync, and experience has
shown that, even though we do have such comments about keeping things in
sync, people actualy do not read those comments and we have seen one
package being bumped but not the other (not just about gettext, but
mesa3d, bluez5, protobuf...)

Maybe it woud make sense to introduce a shared version string, à-la qt5;

    package/gettext/gettext.mk
        GETTEXT_VERSION = 0.22
        include $(wildcard package/gettext/*/*.mk)

    package/gettext/gettext-gnu/gettect-gnu.mk
        GETTEXT_GNU_VERSION = $(GETTEXT_VERSION)

    package/gettext/gettext-tiny/gettext-tiny/mk
        $(SED) 's,@ARCHIVE_VERSION@,$(GETTEXT_VERSION),' $(@D)/gettextize

    package/gettext/libtextstyle/libtextstyle.mk
        LIBTEXTSTYLE_VERSION = $(GETTEXT_VERSION)

But see below....

[--SNIP--]
> +# gettext-tools depends on gettext-runtime
> +define HOST_GETTEXT_GNU_CONFIGURE_RUNTIME
> +	cd $(@D)/$(GETTEXT_GNU_SUBDIR); \

You're mixing the target _SUBDIR with host build; that's not clean.

If we can't have proper separation of tiools and runtime for the host
variant, then let's just stop this dance and build host-gettext at the
root of the package (e.g. let's just drop HOST_GETTEEXT_GNU_SUBDIR).

And see below...

> +		$(HOST_CONFIGURE_OPTS) \
> +		./configure --prefix=$(HOST_DIR) \
> +		$(HOST_GETTEXT_GNU_CONF_OPTS)
> +endef
> +HOST_GETTEXT_GNU_PRE_CONFIGURE_HOOKS += HOST_GETTEXT_GNU_CONFIGURE_RUNTIME
> +
> +define HOST_GETTEXT_GNU_BUILD_RUNTIME
> +	$(HOST_MAKE_ENV) $(MAKE) -C $(@D)/$(GETTEXT_GNU_SUBDIR) install
> +endef
> +HOST_GETTEXT_GNU_PRE_BUILD_HOOKS += HOST_GETTEXT_GNU_BUILD_RUNTIME

As far as I understand, this installs stuff into $(HOST_DIR) at
build time. That is definitely not correct.

What happens when gettext is built as a whole? Certainly, the runtime
library is not installed by the time the tools are built, so the gettext
buildsystem has provising for using as-yet-uninstalled libraries when
linking the tools.

The reason to only build gettext-tools for the host package, was to not
suffer from the whole build time. But if we now need to build the
runtime, then that gain in buildtime is now very limited.

So, back to my porposal above: if we need the runtime for the tools,
then let's build the whole package.

And thus we can drop host-libtextstyle too.

Thoughts?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot